Skip to content

Update BMH CRD from metal3-io/baremetal-operator #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 17, 2021
Merged

Update BMH CRD from metal3-io/baremetal-operator #105

openshift-merge-robot merged 1 commit into from
Feb 17, 2021

Conversation

@honza
Copy link
Member

@honza honza commented Feb 11, 2021

No description provided.

@hardys
Copy link

hardys commented Feb 11, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2021
@hardys
Copy link

hardys commented Feb 11, 2021

@honza lgtm - but note you may want to rebase the BMO PR again, as this also picked up metal3-io/baremetal-operator@6ddbbd2

@hardys
Copy link

hardys commented Feb 15, 2021

/test e2e-agnostic

@dtantsur
Copy link
Member

dtantsur commented Feb 15, 2021

Would it be possible to also include the changes from metal3-io/baremetal-operator#786 or should I propose them separately?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2021
@honza
Copy link
Member Author

honza commented Feb 16, 2021

Would it be possible to also include the changes from metal3-io/baremetal-operator#786 or should I propose them separately?

Done

@hardys
Copy link

hardys commented Feb 16, 2021

/test e2e-agnostic

@hardys
Copy link

hardys commented Feb 16, 2021

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur, hardys, honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021
@hardys
Copy link

hardys commented Feb 16, 2021

/test e2e-agnostic

@hardys hardys mentioned this pull request Feb 17, 2021
Merged
@andfasano
Copy link
Contributor

andfasano commented Feb 17, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2021
@openshift-merge-robot openshift-merge-robot merged commit 591e037 into openshift:master Feb 17, 2021
@hardys hardys mentioned this pull request Mar 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hardys hardys Awaiting requested review from hardys

@kirankt kirankt Awaiting requested review from kirankt

1 more reviewer

@dtantsur dtantsur dtantsur approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hardys hardys

@andfasano andfasano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@honza @hardys @dtantsur @openshift-ci-robot @andfasano @openshift-merge-robot