Delete operator 1 #59

enj · 2019-02-04T21:40:40Z

Delete operator 1

This is the minimal change to remove operator 1. It does not attempt to update operator 2 to remove the "2" or make other cosmetic changes.

Signed-off-by: Monis Khan mkhan@redhat.com

Set operator 2 to Managed

Since operator 1 is gone, operator 2 needs to run by default to allow kube:admin to work.

Signed-off-by: Monis Khan mkhan@redhat.com

/hold

We need the router fixes for this to work. The kube:admin test should fail and prevent this from merging until then.

ericavonb

/lgtm

enj · 2019-02-05T01:17:56Z

fail [github.com/openshift/origin/test/extended/bootstrap_user/bootstrap_user_login.go:52]: Expected error:
    <*util.ExitError | 0xc42293ec60>: {
        Cmd: "oc login --config=/tmp/configfile618696739 --namespace=e2e-test-bootstrap-login-vs8pt -u kubeadmin -p qs83sHr1AzvftWmAw1vWR5yaJX5z9BXWAPoXjMhvfaw",
        StdErr: "error: x509: certificate signed by unknown authority",
        ExitError: {
            ProcessState: {
                pid: 15025,
                status: 256,
                rusage: {
                    Utime: {Sec: 0, Usec: 226357},
                    Stime: {Sec: 0, Usec: 59447},
                    Maxrss: 95120,
                    Ixrss: 0,
                    Idrss: 0,
                    Isrss: 0,
                    Minflt: 15167,
                    Majflt: 0,
                    Nswap: 0,
                    Inblock: 0,
                    Oublock: 0,
                    Msgsnd: 0,
                    Msgrcv: 0,
                    Nsignals: 0,
                    Nvcsw: 1094,
                    Nivcsw: 1,
                },
            },
            Stderr: nil,
        },
    }
    exit status 1
not to have occurred

@sallyom look! A test that catches regressions! It is annoying that the password gets logged though 😑

enj · 2019-02-06T11:57:35Z

/retest

deads2k · 2019-02-06T14:48:30Z

/retest

stlaz · 2019-02-12T07:53:04Z

/hold cancel
The routes were fixed.

derekwaynecarr · 2019-02-13T01:59:12Z

/retest

stlaz · 2019-02-13T16:17:18Z

Currently blocked by openshift/installer#1242

abhinavdahiya · 2019-02-15T17:33:47Z

Currently blocked by openshift/installer#1242
openshift/installer#1242 merged

ericavonb · 2019-02-15T17:35:24Z

/retest

abhinavdahiya · 2019-02-15T18:04:27Z

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-authentication-operator/59/pull-ci-openshift-cluster-authentication-operator-master-e2e-aws/260/
seems stuck in running with no progress...

/test e2e-aws

ericavonb · 2019-02-15T18:39:17Z

/lgtm

abhinavdahiya · 2019-02-15T20:39:24Z

/retest

derekwaynecarr · 2019-02-16T01:48:11Z

/test e2e-aws

nee1esh · 2019-02-17T01:37:48Z

/test e2e-aws

This is the minimal change to remove operator 1. It does not attempt to update operator 2 to remove the "2" or make other cosmetic changes. Signed-off-by: Monis Khan <mkhan@redhat.com>

Since operator 1 is gone, operator 2 needs to run by default to allow kube:admin to work. Signed-off-by: Monis Khan <mkhan@redhat.com>

ericavonb · 2019-02-18T14:41:07Z

/retest

ericavonb · 2019-02-18T14:49:42Z

/lgtm

openshift-ci-robot · 2019-02-18T14:49:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, ericavonb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enj,ericavonb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 4, 2019

openshift-ci-robot requested review from ericavonb and stlaz February 4, 2019 21:41

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2019

openshift-ci-robot assigned ericavonb Feb 4, 2019

ericavonb approved these changes Feb 4, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2019

enj force-pushed the enj/i/cain branch from 4de96c3 to b6b3839 Compare February 6, 2019 14:07

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2019

enj force-pushed the enj/i/cain branch 3 times, most recently from a5b1fe9 to c1c99b1 Compare February 9, 2019 19:24

enj mentioned this pull request Feb 9, 2019

Add support for default key in operator boilerplate #65

Closed

enj force-pushed the enj/i/cain branch from c1c99b1 to 854a136 Compare February 10, 2019 00:30

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2019

This was referenced Feb 14, 2019

Add status updates #36

Merged

operator: change source of apiURL to infrastructure.config.openshift.io #72

Merged

deads2k mentioned this pull request Feb 15, 2019

disable the oauth server in kubeapiserver openshift/origin#22054

Merged

abhinavdahiya mentioned this pull request Feb 15, 2019

Move DNS records from base_domain to cluster_domain openshift/installer#1169

Merged

6 tasks

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2019

sallyom mentioned this pull request Feb 16, 2019

fetch router CA secret instead of configmap, until configmap is reliably created openshift/installer#1260

Closed

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2019

enj added 2 commits February 18, 2019 06:50

Delete operator 1

2796dcc

This is the minimal change to remove operator 1. It does not attempt to update operator 2 to remove the "2" or make other cosmetic changes. Signed-off-by: Monis Khan <mkhan@redhat.com>

Set operator 2 to Managed

a201aa8

Since operator 1 is gone, operator 2 needs to run by default to allow kube:admin to work. Signed-off-by: Monis Khan <mkhan@redhat.com>

enj force-pushed the enj/i/cain branch from 854a136 to a201aa8 Compare February 18, 2019 11:52

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 18, 2019

enj mentioned this pull request Feb 18, 2019

Pull 59 rebase #74

Closed

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2019

openshift-merge-robot merged commit f62d700 into openshift:master Feb 18, 2019

Delete operator 1 #59

Delete operator 1 #59

Uh oh!

Conversation

enj commented Feb 4, 2019

Uh oh!

ericavonb left a comment

Choose a reason for hiding this comment

Uh oh!

enj commented Feb 5, 2019

Uh oh!

enj commented Feb 6, 2019

Uh oh!

deads2k commented Feb 6, 2019

Uh oh!

stlaz commented Feb 12, 2019

Uh oh!

derekwaynecarr commented Feb 13, 2019

Uh oh!

stlaz commented Feb 13, 2019

Uh oh!

abhinavdahiya commented Feb 15, 2019

Uh oh!

ericavonb commented Feb 15, 2019

Uh oh!

abhinavdahiya commented Feb 15, 2019

Uh oh!

ericavonb commented Feb 15, 2019

Uh oh!

abhinavdahiya commented Feb 15, 2019

Uh oh!

derekwaynecarr commented Feb 16, 2019

Uh oh!

nee1esh commented Feb 17, 2019

Uh oh!

ericavonb commented Feb 18, 2019

Uh oh!

ericavonb commented Feb 18, 2019

Uh oh!

openshift-ci-robot commented Feb 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants