Skip to content

Conversation

@ericavonb
Copy link
Contributor

No description provided.

enj added 2 commits February 16, 2019 15:58
This is the minimal change to remove operator 1.  It does not
attempt to update operator 2 to remove the "2" or make other
cosmetic changes.

Signed-off-by: Monis Khan <mkhan@redhat.com>
Since operator 1 is gone, operator 2 needs to run by default to
allow kube:admin to work.

Signed-off-by: Monis Khan <mkhan@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericavonb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 16, 2019
@openshift-ci-robot
Copy link
Contributor

@ericavonb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 2664e38 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ericavonb
Copy link
Contributor Author

@sallyom the kube:admin test is failing because it tries to login before the auth server is ready. (https://bugzilla.redhat.com/show_bug.cgi?id=1678026 reports that login eventually works, making me think it's a readiness issue). Reporting the ClusterOperator status would prevent the install from declaring ready too early, but we can't merge #36 until after this one. Could we amend the test temporarily to wait for the auth deployment or something so that we can get this PR in and then merge #36?

@enj
Copy link
Contributor

enj commented Feb 18, 2019

Rebased #59 to preserve history / git signatures.

/close

@openshift-ci-robot
Copy link
Contributor

@enj: Closed this PR.

Details

In response to this:

Rebased #59 to preserve history / git signatures.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants