Skip to content

disable the oauth server in kubeapiserver #22054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
deads2k merged 1 commit into from
Feb 19, 2019
Merged

disable the oauth server in kubeapiserver #22054

deads2k merged 1 commit into from
Feb 19, 2019

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 15, 2019

The oauthconfig is about to become truly optional. openshift/cluster-authentication-operator#59 is needed.

/assign @mfojtik @soltysh

@deads2k
Copy link
Contributor Author

deads2k commented Feb 15, 2019

@openshift/sig-auth

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 15, 2019
@deads2k deads2k mentioned this pull request Feb 15, 2019
Merged
@mfojtik
Copy link
Contributor

mfojtik commented Feb 15, 2019

LGTM

Will leave it for @enj or @ericavonb to have chance to see and tag.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 15, 2019

/retest

@deads2k
Copy link
Contributor Author

deads2k commented Feb 18, 2019

/rest all

@deads2k
Copy link
Contributor Author

deads2k commented Feb 18, 2019

/retest

@enj
Copy link
Contributor

enj commented Feb 18, 2019

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@stlaz
Copy link
Contributor

stlaz commented Feb 19, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 19, 2019

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 19, 2019

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 152eca3 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 19, 2019 •
edited
Loading

router metrics known flake. merging

@deads2k deads2k merged commit 79c2917 into openshift:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@mfojtik mfojtik

@soltysh soltysh

@enj enj

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@deads2k @mfojtik @enj @openshift-ci-robot @openshift-bot @stlaz @soltysh