Add status updates #36

stlaz · 2019-01-22T09:28:10Z

Adds a library-go controller for status changes and also
adds status failure reporting in auth operator Sync() if an error
occured in the lower level machinery.

Based on current library-go and kube-apiserver-operator code.

stlaz · 2019-01-22T09:28:51Z

pkg/operator2/starter.go

+		[]configv1.ObjectReference{
+			{Group: "authentication.operator.openshift.io", Resource: "authenticationoperatorconfig", Name: globalConfigName},
+			{Resource: "namespaces", Name: targetName},                 // TODO: fix after rename PR?
+			{Resource: "namespaces", Name: "openshift-core-operators"}, // TODO: fix after rename PR?


Do we need more resources here?

stlaz · 2019-01-22T09:31:56Z

The weird order of commits is caused by Github ordering them based on their date rather than the git commit tree order.

stlaz · 2019-01-22T15:00:37Z

/retest

enj · 2019-01-23T02:23:16Z

/hold

Wait for #34

stlaz · 2019-01-24T12:27:12Z

Rebased on top of current master.

stlaz · 2019-01-30T08:38:09Z

Rebased

stlaz · 2019-02-11T12:05:33Z

/hold cancel
#34 was merged long ago

derekwaynecarr · 2019-02-13T02:01:04Z

/test e2e-aws

stlaz · 2019-02-13T10:49:09Z

/retest

stlaz · 2019-02-13T15:48:08Z

For some reason I'm seeing

E0213 15:37:30.023897       1 operator.go:173] error updating operator status: Operation cannot be fulfilled on authentications.operator.openshift.io "cluster": the object has been modified; please apply your changes to the latest version and try again
E0213 15:37:30.027876       1 operator.go:176] error updating operator status: Operation cannot be fulfilled on authentications.operator.openshift.io "cluster": the object has been modified; please apply your changes to the latest version and try again

ericavonb · 2019-02-18T16:30:18Z

/test e2e-aws

stlaz · 2019-02-19T08:50:45Z

/retest

ericavonb · 2019-02-20T02:44:26Z

/retest

stlaz · 2019-02-20T07:37:53Z

/retest

ericavonb · 2019-02-20T13:53:36Z

/retest

stlaz · 2019-02-20T15:31:22Z

/retest

ericavonb · 2019-02-20T20:24:39Z

/retest

ericavonb · 2019-02-20T21:43:37Z

/test e2e-aws-operator

pkg/operator2/starter.go

pkg/operator2/status.go

enj · 2019-02-21T03:12:43Z

pkg/operator2/operator.go

 	}

-	// TODO update states and handle ClusterOperator spec/status
+	if statusErr := c.setAvailableStatus(operatorConfig); statusErr != nil {


This is wholly insufficient - ex: if the deployment fails to rollout we would be stating everything is fine.

pkg/operator2/status.go

enj · 2019-02-21T03:16:08Z

I just did an initial pass review. This is not ready.

This adds a library-go controller for status changes and also adds status failure reporting in auth operator Sync() if an error occured in the lower level machinery. TODO: add a clusteroperator manifest to be deployed by CVO once we are sure we are not breaking anything

stlaz · 2019-02-21T10:01:16Z

Sorry about the sorry state of the PR, I think I originally set it up so that we can build up on it, but even back then it was not very complete.

Most comments are fixed, yet the most important still stands and that's the one about when we should report as available. I'll need to see about that.

enj · 2019-02-22T02:51:07Z

pkg/operator2/starter.go

+	clusterOperatorStatus := status.NewClusterOperatorStatusController(
+		targetName,
+		[]configv1.ObjectReference{
+			{Group: operatorv1.GroupName, Resource: "authentications", Name: globalConfigName},


Also add the infrastructure top level config per #79

ericavonb · 2019-02-22T22:15:13Z

/retest

ericavonb · 2019-02-23T00:44:41Z

/lgtm

openshift-ci-robot · 2019-02-23T00:44:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericavonb, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ericavonb,stlaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ericavonb · 2019-02-23T01:20:27Z

/retest e2e-aws-operator

ericavonb · 2019-02-23T02:01:41Z

/retest

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2019

openshift-ci-robot requested review from abhinavdahiya and deads2k January 22, 2019 09:28

stlaz commented Jan 22, 2019

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2019

stlaz force-pushed the status_updates branch from 6238829 to 4c9b36e Compare January 24, 2019 12:26

stlaz force-pushed the status_updates branch from 4c9b36e to edb1887 Compare January 24, 2019 12:36

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2019

stlaz force-pushed the status_updates branch from edb1887 to 2b591b1 Compare January 30, 2019 08:38

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2019

stlaz mentioned this pull request Jan 30, 2019

Observe publicHostname from top level console config #50

Merged

stlaz force-pushed the status_updates branch from 2b591b1 to 9f29b51 Compare January 30, 2019 09:28

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 30, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 11, 2019

stlaz mentioned this pull request Feb 12, 2019

Operator is not reporting a ClusterOperator resource #67

Closed

stlaz force-pushed the status_updates branch 2 times, most recently from bd505e5 to b38d9e2 Compare February 12, 2019 12:37

stlaz force-pushed the status_updates branch from b38d9e2 to 5772cff Compare February 13, 2019 09:44

stlaz force-pushed the status_updates branch from 5772cff to 2b96b78 Compare February 13, 2019 12:12

stlaz force-pushed the status_updates branch from 99bd92d to b9197f8 Compare February 18, 2019 15:29

stlaz force-pushed the status_updates branch 3 times, most recently from db68724 to 03fd577 Compare February 20, 2019 14:41

enj suggested changes Feb 21, 2019

View reviewed changes

enj removed request for abhinavdahiya and deads2k February 21, 2019 05:03

stlaz added 2 commits February 21, 2019 10:38

fixes to PR commnets1

d89709a

stlaz force-pushed the status_updates branch from 03fd577 to d89709a Compare February 21, 2019 09:55

enj reviewed Feb 22, 2019

View reviewed changes

openshift-ci-robot assigned ericavonb Feb 23, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2019

openshift-merge-robot merged commit 78dd53b into openshift:master Feb 23, 2019

enj mentioned this pull request Feb 23, 2019

Improve status handling #77

Merged

Add status updates #36

Add status updates #36

Uh oh!

Conversation

stlaz commented Jan 22, 2019

Uh oh!

stlaz Jan 22, 2019

Choose a reason for hiding this comment

Uh oh!

stlaz commented Jan 22, 2019

Uh oh!

stlaz commented Jan 22, 2019

Uh oh!

enj commented Jan 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stlaz commented Jan 24, 2019

Uh oh!

stlaz commented Jan 30, 2019

Uh oh!

stlaz commented Feb 11, 2019

Uh oh!

derekwaynecarr commented Feb 13, 2019

Uh oh!

stlaz commented Feb 13, 2019

Uh oh!

stlaz commented Feb 13, 2019

Uh oh!

ericavonb commented Feb 18, 2019

Uh oh!

stlaz commented Feb 19, 2019

Uh oh!

ericavonb commented Feb 20, 2019

Uh oh!

stlaz commented Feb 20, 2019

Uh oh!

ericavonb commented Feb 20, 2019

Uh oh!

stlaz commented Feb 20, 2019

Uh oh!

ericavonb commented Feb 20, 2019

Uh oh!

ericavonb commented Feb 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

enj Feb 21, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

enj commented Feb 21, 2019

Uh oh!

stlaz commented Feb 21, 2019

Uh oh!

enj Feb 22, 2019

Choose a reason for hiding this comment

Uh oh!

ericavonb commented Feb 22, 2019

Uh oh!

ericavonb commented Feb 23, 2019

Uh oh!

openshift-ci-robot commented Feb 23, 2019

Uh oh!

ericavonb commented Feb 23, 2019

Uh oh!

ericavonb commented Feb 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

enj commented Jan 23, 2019 •

edited

Loading