Skip to content

OCPBUGS-29476: openshift: generate separate manifest for core CAPI CRDs#195

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
damdo:openshift-separate-manifests-for-core-capi-crds
Feb 15, 2024
Merged

OCPBUGS-29476: openshift: generate separate manifest for core CAPI CRDs#195
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
damdo:openshift-separate-manifests-for-core-capi-crds

Conversation

@damdo
Copy link
Member

@damdo damdo commented Feb 14, 2024

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly. We want these to be installed independently from whether the cluster-capi-operator is enabled, as other Openshift components rely on them.

This requirement is coming from the need for the SPLAT team to have IPAM core CAPI CRDs in payload even if the platform is not supported.

@openshift-ci openshift-ci bot requested review from elmiko and nrb February 14, 2024 12:34
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@damdo damdo force-pushed the openshift-separate-manifests-for-core-capi-crds branch from e6eb4bb to 854bf69 Compare February 14, 2024 13:13
@damdo damdo force-pushed the openshift-separate-manifests-for-core-capi-crds branch from 854bf69 to 2a4d084 Compare February 14, 2024 15:44
@damdo damdo changed the title openshift: generate separate manifest for core CAPI CRDs OCPBUGS-29476: openshift: generate separate manifest for core CAPI CRDs Feb 14, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2024
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-29476, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly. We want these to be installed independently from whether the cluster-capi-operator is enabled, as other Openshift components rely on them.

This requirement is coming from the need for the SPLAT team to have IPAM core CAPI CRDs in payload even if the platform is not supported.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member Author

damdo commented Feb 14, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 14, 2024
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-29476, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@damdo
Copy link
Member Author

damdo commented Feb 14, 2024

/hold
until the manifests-gen dep replace is removed

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 February 14, 2024 18:42
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
…I CRDs

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly.
We want these to be installed independently from whether the cluster-capi-operator is enabled,
as other Openshift components rely on them.
@damdo damdo force-pushed the openshift-separate-manifests-for-core-capi-crds branch from 2a4d084 to cdc0786 Compare February 15, 2024 10:03
@damdo
Copy link
Member Author

damdo commented Feb 15, 2024

/unhold
manifests-gen dep replace now removed

@damdo damdo requested a review from JoelSpeed February 15, 2024 10:04
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2024
@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2024

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1892065 into openshift:master Feb 15, 2024
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-29476: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29476 has been moved to the MODIFIED state.

Details

In response to this:

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly. We want these to be installed independently from whether the cluster-capi-operator is enabled, as other Openshift components rely on them.

This requirement is coming from the need for the SPLAT team to have IPAM core CAPI CRDs in payload even if the platform is not supported.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-api-container-v4.16.0-202402151410.p0.g1892065.assembly.stream.el9 for distgit ose-cluster-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments