SPLAT-1293: Bump IPAM types to v1beta1.#1205
SPLAT-1293: Bump IPAM types to v1beta1.#1205openshift-merge-bot[bot] merged 3 commits intoopenshift:masterfrom
Conversation
vr4manta
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/retest-required |
|
@: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9b96d630-bafd-11ee-9995-550b1ded175a-0 |
openshift-merge-robot
added
the
needs-rebase
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7a10e0d0-c423-11ee-8e1f-0531b104502e-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/42683e20-c45b-11ee-92c7-743d3894074f-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8aa06140-c4e7-11ee-9545-c342009f33ee-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/15315840-c4ee-11ee-98d7-253093553d1c-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/30230f30-c74c-11ee-8bd4-dc94f1e6188c-0 |
openshift-merge-robot
removed
the
needs-rebase
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/86a3cc20-c9b1-11ee-9dbd-2b39d2735749-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f853b600-c9c5-11ee-884e-0e56387768ce-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5a6ee500-c9d8-11ee-822e-59bc3f2206ae-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5530f340-c9e1-11ee-96d4-95fd07057dd5-0 |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/595caf40-ca68-11ee-8599-ddd5daf65a0e-0 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b5b2020-cc2a-11ee-94e9-34a677c11ec2-0 |
|
@JoelSpeed , with all third-party removed, CRDs no longer being installed via this PR, everything is looking good with the changes to the cluster-api. https://pr-payload-tests.ci.openshift.org/runs/ci/4b5b2020-cc2a-11ee-94e9-34a677c11ec2-0 |
JoelSpeed
left a comment
JoelSpeed
left a comment
There was a problem hiding this comment.
I think the YQ and tools vendor changes can also be dropped now right?
tools/go.mod
Outdated
|
|
||
| require ( | ||
| github.com/ahmetb/gen-crd-api-reference-docs v0.3.0 | ||
| github.com/mikefarah/yq/v4 v4.40.5 |
There was a problem hiding this comment.
Good catch, I'll remove those.
There was a problem hiding this comment.
@JoelSpeed , Reference has been removed.
|
@vr4manta: Here is the PR to promote Core CAPI IPAM CRDs to GA: openshift/cluster-api#197 |
|
@damdo , I have tested the changes with the previous PR and it looks to be installing the CRDs. Thanks! Do you have an image with the current removal of TechPreviewNoUpgrade so I can test real quick? I have not built that image before and figured it might be quicker to just borrow one from you if possible. |
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vr4manta: This PR was included in a payload test run from openshift/installer#7943
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8b4cf8e0-ccd2-11ee-9ec5-3e170f3c0868-0 |
|
@damdo / @JoelSpeed , I ran periodical, grabbed container image, and tested locally w/ my changes with TechPreview not enabled (CI has enabled until all ducks are in the pond), and CRDs were installed and all IPAddress/Claims were initialized as expected. Please go ahead with merge of CRDs w/ TechPreviewNoUpgrade removed. Thanks! |
|
/test e2e-vsphere-ovn-serial e2e-vsphere-operator |
|
/test e2e-vsphere-ovn |
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@vr4manta: This pull request references SPLAT-1293 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-vsphere-ovn-serial |
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override security/snyk Having reviewed the snyk scan, it's complaining about an indirect dependency that isn't actually indirect in this repository. We are not exposed since we aren't importing the package from nats at all, it's not present in our vendor. |
|
@JoelSpeed: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override security/snyk (OpenShift-CI (INTERNAL)) |
|
@JoelSpeed: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override "security/snyk (OpenShift-CI (INTERNAL))" |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: security/snyk (OpenShift-CI (INTERNAL)) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-machine-api-operator-container-v4.16.0-202402231540.p0.g905a0ef.assembly.stream.el9 for distgit ose-machine-api-operator. |
7 participants
SPLAT-1293
Changes
Dependencies