Skip to content

[release-4.15] OCPBUGS-29515: openshift: generate separate manifest for core CAPI CRDs#198

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
damdo:release-4.15-store-capi-crds-in-own-manifests
Feb 29, 2024
Merged

[release-4.15] OCPBUGS-29515: openshift: generate separate manifest for core CAPI CRDs#198
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
damdo:release-4.15-store-capi-crds-in-own-manifests

Conversation

@damdo
Copy link
Member

@damdo damdo commented Feb 19, 2024

Manual backport of #195

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly. We want these to be installed independently from whether the cluster-capi-operator is enabled, as other Openshift components rely on them.

This requirement is coming from the need for the SPLAT team to have IPAM core CAPI CRDs in payload even if the platform is not supported.

TODO:

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Feb 19, 2024
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-29515, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29476 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29476 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @miyadav

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual backport of #195

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly. We want these to be installed independently from whether the cluster-capi-operator is enabled, as other Openshift components rely on them.

This requirement is coming from the need for the SPLAT team to have IPAM core CAPI CRDs in payload even if the platform is not supported.

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
…I CRDs

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly.
We want these to be installed independently from whether the cluster-capi-operator is enabled,
as other Openshift components rely on them.
@damdo damdo force-pushed the release-4.15-store-capi-crds-in-own-manifests branch from 29096ba to b786309 Compare February 27, 2024 18:05
@damdo
Copy link
Member Author

damdo commented Feb 27, 2024

/retest

1 similar comment
@damdo
Copy link
Member Author

damdo commented Feb 27, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2024

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-capi-techpreview b786309 link false /test e2e-aws-capi-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 28, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@openshift-ci
Copy link

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunzhaohua2
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 29, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD db1841a and 2 for PR HEAD b786309 in total

@openshift-merge-bot openshift-merge-bot bot merged commit c3b9ac8 into openshift:release-4.15 Feb 29, 2024
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-29515: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29515 has been moved to the MODIFIED state.

Details

In response to this:

Manual backport of #195

Store Core CAPI CRDs in their own manifest to get them applied by CVO directly. We want these to be installed independently from whether the cluster-capi-operator is enabled, as other Openshift components rely on them.

This requirement is coming from the need for the SPLAT team to have IPAM core CAPI CRDs in payload even if the platform is not supported.

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-api-container-v4.15.0-202402290407.p0.gc3b9ac8.assembly.stream.el9 for distgit ose-cluster-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments