CORS-2750: Move to rhel9, decouple from cli image

[joepvd]

List all the issues related to this PR

Move the image to rhel9. To do so, the openshift-clients rpm is installed rather than the oc binary plucked from the cli image.

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (9823c09) to head (4f6d88c).
Report is 63 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5792      +/-   ##
==========================================
+ Coverage   68.40%   70.38%   +1.97%     
==========================================
  Files         239      246       +7     
  Lines       35457    41244    +5787     
==========================================
+ Hits        24256    29030    +4774     
- Misses       9098     9787     +689     
- Partials     2103     2427     +324     

see 38 files with indirect coverage changes

[openshift-ci-robot]

@joepvd: This pull request references Jira Issue OCPBUGS-25037, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (lalon@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

List all the issues related to this PR

Move the image to rhel9. To do so, the openshift-clients rpm is installed rather than the oc binary plucked from the cli image.

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[joepvd]

/retest

[adriengentil]

/retest

[joepvd]

/hold
brew is not ready yet to build on rhel9

[joepvd]

/unhold
Successful build: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=2950260

[adriengentil]

/retest
/cc @andfasano

[zaneb]

For the e2e-agent-compact-ipv4 build (which has FIPS enabled) to pass, we need the assisted-service container to also be RHEL9-based.
Of course changing that one first will also fail. Since we can't make the change atomic we'll have to have both PRs ready to go, override the tests, and merge both as close together as possible.

[joepvd]

Successful test build with this PR and openshift/assisted-installer#760 and openshift-eng/ocp-build-data#4659:

• ose-agent-installer-api-server-container-v4.16.0-202404150400.p0.g4f6d88c.assembly.test.el9
• ose-agent-installer-csr-approver-container-v4.16.0-202404150400.p0.gd8dd7cb.assembly.test.el9

[zaneb]

/retitle CORS-2750: Move to rhel9, decouple from cli image

[openshift-ci-robot]

@joepvd: This pull request references CORS-2750 which is a valid jira issue.

Details

In response to this:

List all the issues related to this PR

Move the image to rhel9. To do so, the openshift-clients rpm is installed rather than the oc binary plucked from the cli image.

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[joepvd]

/hold
Needs to go together with openshift/installer#8196

[carbonin]

/lgtm

[carbonin]

/override ci/prow/e2e-agent-compact-ipv4

[carbonin]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, joepvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [carbonin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@carbonin: Overrode contexts on behalf of carbonin: ci/prow/e2e-agent-compact-ipv4

Details

In response to this:

/override ci/prow/e2e-agent-compact-ipv4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thegreyd]

/unhold

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8c73c0e and 2 for PR HEAD 4f6d88c in total

[zaneb]

/retest-required

[zaneb]

edge-e2e-metal-assisted tests are failing with:

[2024-04-30 22:16:51] openshift-tests: /lib64/libc.so.6: version `GLIBC_2.34'\'' not found (required by openshift-tests)
[2024-04-30 22:16:51] openshift-tests: /lib64/libc.so.6: version `GLIBC_2.32'\'' not found (required by openshift-tests)'

but it is not due to this PR (other PRs have the same error). Presumably it is caused by openshift/origin#28733

[zaneb]

I don't think I can override, but I'll give it a go because this is blocking openshift-eng/ocp-build-data#4659 which is blocking the agent release informing job.
/override ci/prow/edge-e2e-metal-assisted

[openshift-ci]

@zaneb: Overrode contexts on behalf of zaneb: ci/prow/edge-e2e-metal-assisted

Details

In response to this:

I don't think I can override, but I'll give it a go because this is blocking openshift-eng/ocp-build-data#4659 which is blocking the agent release informing job.
/override ci/prow/edge-e2e-metal-assisted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@joepvd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.17.0-202405010518.p0.g6a70f70.assembly.stream.el9 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.