CORS-2750: Move to rhel9, decouple from cli image by joepvd · Pull Request #760 · openshift/assisted-installer

joepvd · 2023-12-09T11:54:11Z

No description provided.

openshift-ci-robot · 2023-12-11T08:42:18Z

@joepvd: This pull request references Jira Issue OCPBUGS-25037, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (lalon@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joepvd · 2023-12-11T08:44:39Z

/retest

adriengentil · 2023-12-11T15:48:58Z

/retest

adriengentil · 2023-12-11T16:52:54Z

/retest

codecov · 2023-12-11T17:09:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.52%. Comparing base (81ef854) to head (d8dd7cb).
Report is 30 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   56.33%   60.52%   +4.19%     
==========================================
  Files          15       17       +2     
  Lines        3220     4540    +1320     
==========================================
+ Hits         1814     2748     +934     
- Misses       1241     1620     +379     
- Partials      165      172       +7

see 11 files with indirect coverage changes

rccrdpccl · 2023-12-11T19:49:33Z

/retest

rccrdpccl · 2023-12-12T11:34:39Z

/lgtm
/approve

openshift-ci · 2023-12-12T11:36:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joepvd, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rccrdpccl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

joepvd · 2023-12-12T11:52:53Z

/hold
brew is not ready yet to build this component on rhel9

openshift-bot · 2024-01-01T00:00:41Z

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

openshift-ci-robot · 2024-01-01T00:01:16Z

@openshift-bot: This pull request references Jira Issue OCPBUGS-25037, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (lalon@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift/assisted-service#5792 openshift/assisted-installer#760

joepvd · 2024-04-15T08:50:34Z

/unhold
Successful test build with this PR and #760 and openshift-eng/ocp-build-data#4659:

openshift/assisted-service#5792 openshift/assisted-installer#760

rccrdpccl · 2024-04-15T11:30:23Z

/cc @carbonin

carbonin · 2024-04-15T15:46:13Z

If it's been tested in brew I'm assuming the required downstream changes have been made, removing the label.

openshift-ci-robot · 2024-04-15T18:45:06Z

/retest-required

Remaining retests: 0 against base HEAD 236a7a0 and 2 for PR HEAD d8dd7cb in total

joepvd · 2024-04-16T07:47:50Z

The test error might have to do with this comment. Think we'd need to override the tests on both.

zaneb · 2024-04-16T08:19:20Z

The test error might have to do with this comment. Think we'd need to override the tests on both.

I think that job is permafailing for everyone.
As far as I know, that comment only applies to assisted-service; this one should be able to merge any time.

zaneb · 2024-04-16T09:48:47Z

/retitle CORS-2750: Move to rhel9, decouple from cli image

openshift-ci-robot · 2024-04-16T09:49:31Z

@joepvd: This pull request references CORS-2750 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

zaneb · 2024-04-17T02:14:10Z

/retest
CI was failing due to https://issues.redhat.com/browse/OCPBUGS-32331

rccrdpccl · 2024-04-17T11:24:07Z

/retest

openshift-ci · 2024-04-17T12:28:11Z

@joepvd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2024-04-18T16:46:16Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-orchestrator-container-v4.16.0-202404181209.p0.g76f9a49.assembly.stream.el9 for distgit ose-agent-installer-orchestrator.
All builds following this will include this PR.

Move to rhel9, decouple from cli image

d8dd7cb

openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2023

openshift-ci Bot requested review from jhernand and omertuc December 9, 2023 11:54

openshift-ci Bot added the downstream-change-needed Requires updating downstream image label Dec 9, 2023

joepvd changed the title ~~wip: Move to rhel9, decouple from cli image~~ OCPBUGS-25037: Move to rhel9, decouple from cli image Dec 11, 2023

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2023

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2023

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 11, 2023

openshift-ci Bot assigned rccrdpccl Dec 12, 2023

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2023

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2023

joepvd added a commit to joepvd/ocp-build-data that referenced this pull request Apr 15, 2024

agent-installer* to rhel9

1622b9c

openshift/assisted-service#5792 openshift/assisted-installer#760

joepvd added a commit to joepvd/ocp-build-data that referenced this pull request Apr 15, 2024

agent-installer* to rhel9

6314c78

openshift/assisted-service#5792 openshift/assisted-installer#760

This was referenced Apr 15, 2024

agent-installer-api-server to rhel9 openshift-eng/ocp-build-data#4659

Merged

CORS-2750: Move to rhel9, decouple from cli image openshift/assisted-service#5792

Merged

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024

joepvd added a commit to joepvd/ocp-build-data that referenced this pull request Apr 15, 2024

agent-installer* to rhel9

d12f2c6

openshift/assisted-service#5792 openshift/assisted-installer#760

openshift-ci Bot requested a review from carbonin April 15, 2024 11:30

carbonin removed the downstream-change-needed Requires updating downstream image label Apr 15, 2024

openshift-ci Bot changed the title ~~OCPBUGS-25037: Move to rhel9, decouple from cli image~~ CORS-2750: Move to rhel9, decouple from cli image Apr 16, 2024

openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 16, 2024

openshift-merge-bot Bot merged commit 76f9a49 into openshift:master Apr 17, 2024

joepvd mentioned this pull request May 4, 2024

OCPBUGS-24826: Updating ose-agent-installer-csr-approver-container image to be consistent with ART #759

Closed

Uh oh!

Conversation

joepvd commented Dec 9, 2023

Uh oh!

openshift-ci-robot commented Dec 11, 2023

Uh oh!

joepvd commented Dec 11, 2023

Uh oh!

adriengentil commented Dec 11, 2023

Uh oh!

adriengentil commented Dec 11, 2023

Uh oh!

codecov Bot commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rccrdpccl commented Dec 11, 2023

Uh oh!

rccrdpccl commented Dec 12, 2023

Uh oh!

openshift-ci Bot commented Dec 12, 2023

Uh oh!

joepvd commented Dec 12, 2023

Uh oh!

openshift-bot commented Jan 1, 2024

Uh oh!

openshift-ci-robot commented Jan 1, 2024

Uh oh!

joepvd commented Apr 15, 2024

Uh oh!

rccrdpccl commented Apr 15, 2024

Uh oh!

carbonin commented Apr 15, 2024

Uh oh!

openshift-ci-robot commented Apr 15, 2024

Uh oh!

joepvd commented Apr 16, 2024

Uh oh!

zaneb commented Apr 16, 2024

Uh oh!

zaneb commented Apr 16, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 16, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zaneb commented Apr 17, 2024

Uh oh!

rccrdpccl commented Apr 17, 2024

Uh oh!

openshift-ci Bot commented Apr 17, 2024

Uh oh!

openshift-bot commented Apr 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Dec 11, 2023 •

edited

Loading

zaneb commented Apr 16, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 16, 2024 •

edited by openshift-ci Bot

Loading