config: support for other Azure cloud environments #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
/lgtm |
Contributor
|
/assign @deads2k @derekwaynecarr |
staebler
force-pushed
the
azure_other_cloud_env
branch
from
fe60d75 to
fa48456
Compare
Contributor
Author
|
Add the `.status.platformStatus.azure.cloudName` field to the Infrastructure type in config. This field informs in which Azure cloud environment the cluster is installed and consequently which Azure API endpoint should be used when communicating via the Azure SDK. See openshift/enhancements#321 https://issues.redhat.com/browse/CORS-1441
staebler
force-pushed
the
azure_other_cloud_env
branch
from
fa48456 to
f4bb75a
Compare
Contributor
Author
|
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
May 20, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. openshift/api#650
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
May 20, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. openshift/api#650
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
May 20, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. openshift/api#650
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
May 20, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1444
staebler
added a commit
to staebler/cluster-ingress-operator
that referenced
this pull request
May 20, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Changes from openshift/api#650 See openshift/enhancements#321
Contributor
|
/approve |
openshift-ci-robot
added
the
approved
staebler
added a commit
to staebler/cloud-credential-operator
that referenced
this pull request
May 22, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. This also required manually bumping the following. k8s.io/client-go v0.18.2 sigs.k8s.io/controller-runtime v0.6.0 Changes from openshift/api#650 See openshift/enhancements#321
staebler
added a commit
to staebler/cloud-credential-operator
that referenced
this pull request
May 22, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. This also required manually bumping the following. k8s.io/client-go v0.18.2 sigs.k8s.io/controller-runtime v0.6.0 Changes from openshift/api#650 See openshift/enhancements#321
staebler
added a commit
to staebler/cloud-credential-operator
that referenced
this pull request
May 22, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Repalced github.com/jteeuwen/go-bindata with github.com/go-bindata/go-bindata. Manually bumped the following. k8s.io/client-go v0.18.2 sigs.k8s.io/controller-runtime v0.6.0 Changes from openshift/api#650 See openshift/enhancements#321
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
staebler
added a commit
to staebler/installer
that referenced
this pull request
Jun 3, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1442
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
Jun 15, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1444
staebler
added a commit
to staebler/cloud-credential-operator
that referenced
this pull request
Jun 15, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Repalced github.com/jteeuwen/go-bindata with github.com/go-bindata/go-bindata. Manually bumped the following. k8s.io/client-go v0.18.2 sigs.k8s.io/controller-runtime v0.6.0 Changes from openshift/api#650 See openshift/enhancements#321
staebler
added a commit
to staebler/cluster-ingress-operator
that referenced
this pull request
Jun 15, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Changes from openshift/api#650 See openshift/enhancements#321
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
Jun 16, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1444
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
Jun 16, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1444
staebler
added a commit
to staebler/cluster-config-operator
that referenced
this pull request
Jun 16, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1444
jhixson74
pushed a commit
to jhixson74/cluster-config-operator
that referenced
this pull request
Jun 19, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1444
jhixson74
pushed a commit
to jhixson74/cluster-config-operator
that referenced
this pull request
Jun 23, 2020
Bump to the latest github.com/openshift/api version in order to pick up changes to the infrastructure.config.openshift.io type for supporting other Azure cloud environments. Changes from openshift/api#650. https://issues.redhat.com/browse/CORS-1444
staebler
added a commit
to staebler/cluster-ingress-operator
that referenced
this pull request
Jul 12, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Changes from openshift/api#650 See openshift/enhancements#321
staebler
added a commit
to staebler/cluster-ingress-operator
that referenced
this pull request
Jul 22, 2020
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Changes from openshift/api#650 See openshift/enhancements#321
ming1013
pushed a commit
to ming1013/cloud-credential-operator
that referenced
this pull request
Dec 15, 2025
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Repalced github.com/jteeuwen/go-bindata with github.com/go-bindata/go-bindata. Manually bumped the following. k8s.io/client-go v0.18.2 sigs.k8s.io/controller-runtime v0.6.0 Changes from openshift/api#650 See openshift/enhancements#321
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
.status.azure.cloudNamefield to the Infrastructure type in config. This field informs in which Azure cloud environment the cluster is installed and consequently which Azure API endpoint should be used when communicating via the Azure SDK.See openshift/enhancements#321
https://issues.redhat.com/browse/CORS-1441