Skip to content

support other Azure cloud environments #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jul 24, 2020
Merged

support other Azure cloud environments #403

openshift-merge-robot merged 2 commits into from
Jul 24, 2020

Conversation

@staebler
Copy link
Contributor

@staebler staebler commented May 20, 2020

Use the Azure cloud environment specified by the status.platformStatus.azure.cloudName field of the infrastructure.config.openshift.io resource.

See openshift/enhancements#321

@staebler
Copy link
Contributor Author

staebler commented May 20, 2020

/hold

This is currently vendoring an openshift/api fork until openshift/api#650 merges.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 20, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2020
@staebler staebler force-pushed the azure_other_cloud_env branch from a79b1ac to 8c401e9 Compare June 15, 2020 14:34
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2020
@staebler
Copy link
Contributor Author

staebler commented Jun 15, 2020

a79b1ac...8c401e9

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2020
@Miciah
Copy link
Contributor

Miciah commented Jul 11, 2020

@staebler, this PR needs to be rebased for #417, which moved client creation from start.go to pkg/operator/controller/dns/controller.go. Do you want to do the rebase, or shall I open a new PR?

@staebler staebler force-pushed the azure_other_cloud_env branch from 8c401e9 to 93a8c62 Compare July 12, 2020 01:46
@staebler
Copy link
Contributor Author

staebler commented Jul 12, 2020

@staebler, this PR needs to be rebased for #417, which moved client creation from start.go to pkg/operator/controller/dns/controller.go. Do you want to do the rebase, or shall I open a new PR?

I have done the rebase.

@Miciah
Copy link
Contributor

Miciah commented Jul 12, 2020

/test e2e-aws-operator

staebler added 2 commits July 22, 2020 19:31
@staebler
support other Azure cloud environments
9b5a597 
Use the Azure cloud environment specified by the
`status.platformStatus.azure.cloudName` field of the
infrastructure.config.openshift.io resource.

See openshift/enhancements#321
@staebler
vendor: bump to latest openshift/api
6e192f8 
Bump to the latest of github.com/openshift/api to pull in the
addition of the `status.platformStatus.azure.cloudName`
field of the infrastructure.config.openshift.io in order to
support other Azure cloud environments.

Changes from openshift/api#650

See openshift/enhancements#321
@staebler staebler force-pushed the azure_other_cloud_env branch from 93a8c62 to 6e192f8 Compare July 22, 2020 23:32
@staebler
Copy link
Contributor Author

staebler commented Jul 22, 2020

93a8c62...6e192f8

  • Rebased onto master
  • Specify the base URI when creating Azure clients.

@staebler
Copy link
Contributor Author

staebler commented Jul 22, 2020

/test e2e-azure

@staebler
Copy link
Contributor Author

staebler commented Jul 23, 2020

Results for testing this on a cluster installed on Azure Gov Cloud.

$ oc get clusteroperator ingress
NAME      VERSION                   AVAILABLE   PROGRESSING   DEGRADED   SINCE
ingress   0.0.1-2020-07-23-130820   True        False         False      12m

$ oc -n openshift-ingress-operator get dnsrecords -o yaml | yq -y '.items[] | (.spec, .status)'
dnsName: '*.apps.mstaeble.groupgmag.azure.devcluster.openshift.com.'
recordTTL: 30
recordType: A
targets:
  - 20.140.191.176
---
observedGeneration: 1
zones:
  - conditions:
      - lastTransitionTime: '2020-07-23T13:58:38Z'
        message: The DNS provider succeeded in ensuring the record
        reason: ProviderSuccess
        status: 'False'
        type: Failed
    dnsZone:
      id: /subscriptions/XXX/resourceGroups/mstaeble-njbbb-rg/providers/Microsoft.Network/privateDnsZones/mstaeble.groupgmag.azure.devcluster.openshift.com
  - conditions:
      - lastTransitionTime: '2020-07-23T13:58:38Z'
        message: The DNS provider succeeded in ensuring the record
        reason: ProviderSuccess
        status: 'False'
        type: Failed
    dnsZone:
      id: /subscriptions/XXX/resourceGroups/os4-common/providers/Microsoft.Network/dnszones/groupgmag.azure.devcluster.openshift.com

$ curl -kIs https://console-openshift-console.apps.mstaeble.groupgmag.azure.devcluster.openshift.com | head -n1
HTTP/1.1 200 OK

@Miciah
Copy link
Contributor

Miciah commented Jul 23, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 23, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 60719c5 into openshift:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@Miciah Miciah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@staebler @Miciah @openshift-ci-robot @openshift-bot @openshift-merge-robot