support other Azure cloud environments #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
Contributor
Author
|
/hold This is currently vendoring an openshift/api fork until openshift/api#650 merges. |
openshift-ci-robot
added
the
do-not-merge/hold
staebler
force-pushed
the
azure_other_cloud_env
branch
2 times, most recently
from
7fcbae1 to
c6ad0bf
Compare
joelddiaz
reviewed
May 26, 2020
Contributor
|
lgtm once this starts vendoring openshift/api |
openshift-ci-robot
added
the
needs-rebase
Use the Azure cloud environment specified by the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io resource. See openshift/enhancements#321
Bump to the latest of github.com/openshift/api to pull in the addition of the `status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io in order to support other Azure cloud environments. Repalced github.com/jteeuwen/go-bindata with github.com/go-bindata/go-bindata. Manually bumped the following. k8s.io/client-go v0.18.2 sigs.k8s.io/controller-runtime v0.6.0 Changes from openshift/api#650 See openshift/enhancements#321
staebler
force-pushed
the
azure_other_cloud_env
branch
from
c6ad0bf to
f66835e
Compare
openshift-ci-robot
removed
the
needs-rebase
Contributor
Author
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelddiaz, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/test e2e-aws-upgrade |
ming1013
pushed a commit
to ming1013/cloud-credential-operator
that referenced
this pull request
Dec 15, 2025
support other Azure cloud environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the Azure cloud environment specified by the
status.platformStatus.azure.cloudNamefield of the infrastructure.config.openshift.io resource.See openshift/enhancements#321