kube_cloud_config: support for other Azure cloud environments #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
needs-rebase
staebler
force-pushed
the
azure_other_cloud_env
branch
from
fe1b6b9 to
415f494
Compare
openshift-ci-robot
removed
the
needs-rebase
Contributor
Author
|
/hold This is currently vendoring an openshift/api fork until openshift/api#650 merges. |
openshift-ci-robot
added
the
do-not-merge/hold
staebler
force-pushed
the
azure_other_cloud_env
branch
2 times, most recently
from
346a2aa to
7f5aeff
Compare
Contributor
Author
|
staebler
force-pushed
the
azure_other_cloud_env
branch
from
7f5aeff to
9656e5d
Compare
Contributor
Author
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
Member
|
/approve |
Contributor
|
/test e2e-azure |
1 similar comment
Contributor
Author
|
/test e2e-azure |
Contributor
Author
|
/hold The machine config is not getting generated. The masters are stuck using 99-master-generated-registries. |
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
Author
The cluster-config-operator is writing out a different cloud.conf, which is causing the machine-config-operator to render a different machineconfig. The machine-config daemon running in bootstrap node is looking for the first hash, before the cluster-config-operator changes. |
staebler
force-pushed
the
azure_other_cloud_env
branch
from
9656e5d to
1a7e4e0
Compare
Contributor
Author
|
staebler
force-pushed
the
azure_other_cloud_env
branch
from
1a7e4e0 to
7299eac
Compare
Contributor
Author
|
staebler
force-pushed
the
azure_other_cloud_env
branch
from
7299eac to
4dc1e74
Compare
Contributor
Author
|
/test e2e-azure |
Contributor
Author
|
The azure tests look to be failing to create the worker nodes. I assume this is due to the bug where the validation is rejecting changes to the machine when This may have been the underlying cause of the masters not being able to transition to the new state after the cloud.conf was changed. So my recent changes to this PR may not have been necessary. I think it is better that the cluster-config-operator does not change the cloud.conf if it does not have to. But this does require copying type from https://github.com/kubernetes/kubernetes/blob/v1.13.5/pkg/cloudprovider/providers/azure. I had been hesitant to do that since it introduces something else that may become out-of-sync and is not easy to discover. I could change it to use the incoming cloud.conf unmodified when the cloud already matches and fall back to alphabetical ordering when a change is necessary? |
Contributor
Author
|
/test e2e-azure |
Contributor
Author
|
/test e2e-azure |
Contributor
|
/retest |
Contributor
|
/lgtm |
Contributor
|
shows the installs are completing.. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
sttts
reviewed
Jun 23, 2020
| k8s.io/api v0.18.2 | ||
| k8s.io/apimachinery v0.18.2 | ||
| k8s.io/api v0.18.3 | ||
| k8s.io/apimachinery v0.18.3 |
Contributor
|
Needs rebase. See version skew nit. Otherwise, sgtm. |
Populate the `cloud` field in kube cloud.conf stored in the kube-cloud-config ConfigMap in the openshift-config-managed namespace. This field informs in which Azure cloud environment the cluster is installed and consequently which Azure API endpoint should be used when communicating via the Azure SDK. The value populated comes from the `.status.platformStatus.azure.cloudName` field of the infrastructure.config.openshift.io resource. If the field is empty or missing, then the default "AzurePublicCloud" value is set for the `cloud` field in the kube cloud config. If the field generated from the infrastructure resource conflicts with the field in the user-provided kube cloud config, then the controller will error on syncing the infrastructure resource. See openshift/enhancements#321 https://issues.redhat.com/browse/CORS-1444
staebler
force-pushed
the
azure_other_cloud_env
branch
from
ec4ebaa to
bf88b22
Compare
Contributor
Author
The version of openshift/api has already been bumped in master, so the commit bumping the version in this PR has been removed. |
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jhixson74, staebler, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Dec 22, 2023
This change adds the functionality from the cluster-config-operator
azure CloudConfigTransformer.
The functionality we bring over is:
1. Ensure that the Cloud is set in the cloud.conf
i. If it is set, verify that it is valid and does not conflict with the
infrastructure config. If it conflicts, we want to error
ii. If it is not set, default to public cloud (configv1.AzurePublicCloud)
2. Verify the cloud name set in the infra config is valid, if it is not
bail with an informative error
See openshift/cluster-config-operator#133 for
the PR that initially added this functionality.
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 5, 2024
This change adds the functionality from the cluster-config-operator
azure CloudConfigTransformer.
The functionality we bring over is:
1. Ensure that the Cloud is set in the cloud.conf
i. If it is set, verify that it is valid and does not conflict with the
infrastructure config. If it conflicts, we want to error
ii. If it is not set, default to public cloud (configv1.AzurePublicCloud)
2. Verify the cloud name set in the infra config is valid, if it is not
bail with an informative error
See openshift/cluster-config-operator#133 for
the PR that initially added this functionality.
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 5, 2024
This change adds the functionality from the cluster-config-operator
azure CloudConfigTransformer.
The functionality we bring over is:
1. Ensure that the Cloud is set in the cloud.conf
i. If it is set, verify that it is valid and does not conflict with the
infrastructure config. If it conflicts, we want to error
ii. If it is not set, default to public cloud (configv1.AzurePublicCloud)
2. Verify the cloud name set in the infra config is valid, if it is not
bail with an informative error
See openshift/cluster-config-operator#133 for
the PR that initially added this functionality.
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 5, 2024
This change adds the functionality from the cluster-config-operator
azure CloudConfigTransformer.
The functionality we bring over is:
1. Ensure that the Cloud is set in the cloud.conf
i. If it is set, verify that it is valid and does not conflict with the
infrastructure config. If it conflicts, we want to error
ii. If it is not set, default to public cloud (configv1.AzurePublicCloud)
2. Verify the cloud name set in the infra config is valid, if it is not
bail with an informative error
See openshift/cluster-config-operator#133 for
the PR that initially added this functionality.
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 10, 2024
This change adds the functionality from the cluster-config-operator
azure CloudConfigTransformer.
The functionality we bring over is:
1. Ensure that the Cloud is set in the cloud.conf
i. If it is set, verify that it is valid and does not conflict with the
infrastructure config. If it conflicts, we want to error
ii. If it is not set, default to public cloud (configv1.AzurePublicCloud)
2. Verify the cloud name set in the infra config is valid, if it is not
bail with an informative error
See openshift/cluster-config-operator#133 for
the PR that initially added this functionality.
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 10, 2024
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 10, 2024
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 10, 2024
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
theobarberbany
added a commit
to theobarberbany/cluster-cloud-controller-manager-operator
that referenced
this pull request
Jan 10, 2024
This adds a CloudConfigTransformer for Azure that will set the VMType to 'standard' if unset. See openshift#291, OCPBUGS-25483 and OCPBUGS-20213 for more information. This change also adds the functionality from the cluster-config-operator azure CloudConfigTransformer. The functionality we bring over is: 1. Ensure that the Cloud is set in the cloud.conf i. If it is set, verify that it is valid and does not conflict with the infrastructure config. If it conflicts, we want to error ii. If it is not set, default to public cloud (configv1.AzurePublicCloud) 2. Verify the cloud name set in the infra config is valid, if it is not bail with an informative error See openshift/cluster-config-operator#133 for the PR that initially added this functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate the
cloudfield in kube cloud.conf stored in the kube-cloud-config ConfigMap in the openshift-config-managed namespace. This field informs in which Azure cloud environment the cluster is installed and consequently which Azure API endpoint should be used when communicating via the Azure SDK.The value populated comes from the
.status.platformStatus.azure.cloudNamefield of the infrastructure.config.openshift.io resource. If the field is empty or missing, then the default "AZUREPUBLICCLOUD" value is set for thecloudfield in the kube cloud config. If the field generated from the infrastructure resource conflicts with the field in the user-provided kubecloud config, then the controller will error on syncing the infrastructure resource.
See openshift/enhancements#321
https://issues.redhat.com/browse/CORS-1444