Skip to content

Conversation

@alebedev87
Copy link
Contributor

Retake of #1516.

Enhancement Proposal: openshift/enhancements#1415.

This PR introduces a new Ingress cluster capability which allows to enable or disable the default ingress of the OpenShift cluster: the cluster ingress operator and its custom resources. The Ingress capability is added to a new 4.16 capabilityset as it's the first capability added for 4.16. The two CRDs managed by the cluster ingress operator are annotated with Ingress capability: IngressController, DNSRecord.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 12, 2024

Hello @alebedev87! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 12, 2024
@openshift-ci openshift-ci bot requested review from bparees and mfojtik January 12, 2024 10:39
@alebedev87 alebedev87 changed the title cluster version: add v4.16 set and ingress capability NE-1303: cluster version: add v4.16 set and ingress capability Jan 12, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 12, 2024

@alebedev87: This pull request references NE-1303 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Retake of #1516.

Enhancement Proposal: openshift/enhancements#1415.

This PR introduces a new Ingress cluster capability which allows to enable or disable the default ingress of the OpenShift cluster: the cluster ingress operator and its custom resources. The Ingress capability is added to a new 4.16 capabilityset as it's the first capability added for 4.16. The two CRDs managed by the cluster ingress operator are annotated with Ingress capability: IngressController, DNSRecord.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

/test e2e-gcp

@bparees
Copy link
Contributor

bparees commented Jan 29, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@alebedev87 alebedev87 force-pushed the ingress-capability-4-16 branch from 839cc33 to faf8a6a Compare February 5, 2024 09:23
@alebedev87
Copy link
Contributor Author

Rebased to fix the conflicts with master.

@alebedev87
Copy link
Contributor Author

/assign @Miciah

@Miciah
Copy link
Contributor

Miciah commented Feb 13, 2024

Thanks!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, bparees, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 06532f4 into openshift:master Feb 13, 2024
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202402130340.p0.g06532f4.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants