Skip to content

NE-1316: bump openshift api to add ingress capability #7370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alebedev87 wants to merge 1 commit into from
Closed

NE-1316: bump openshift api to add ingress capability #7370

alebedev87 wants to merge 1 commit into from

Conversation

@alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Jul 26, 2023 •
edited
Loading

This PR bumps the OpenShift API to the version which has with the ingress capability. The v4.16 capabilityset is added along the way because Ingress is the first new capability of 4.16. The API PR which adds the ingress capability is a prerequisite.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 26, 2023 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1316 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@openshift-ci openshift-ci bot requested review from rwsu and sadasu July 26, 2023 08:52
@alebedev87 alebedev87 force-pushed the ingress-capability branch from 6e4c55f to 71397b2 Compare July 26, 2023 09:21
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2023
@sadasu
Copy link
Contributor

sadasu commented Feb 2, 2024

@alebedev87 is this PR and corresponding openshift/api version bump still required?

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2024 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1316 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This PR adds the api with the ingress capability. The API PR is a prerequisite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Feb 5, 2024

Rebased from master + added the latest api with the ingress capability from openshift/api#1724.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Feb 5, 2024

@sadasu : I recreated the API PR so I still plan to bump it in the installer.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2024 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1316 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This PR bumps the OpenShift API to the version which has with the ingress capability. The API PR which adds the ingress capability is a prerequisite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 5, 2024 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1316 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This PR bumps the OpenShift API to the version which has with the ingress capability. The v4.16 capabilityset is added along the way because Ingress is the first new capability of 4.16. The API PR which adds the ingress capability is a prerequisite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Feb 26, 2024 •
edited
Loading

/retitle NE-1316: bump openshift api to add ingress capability

PR's ready for a review.

@openshift-ci openshift-ci bot changed the title [WIP] NE-1316: bump openshift api to add ingress capability NE-1316: bump openshift api to add ingress capability Feb 26, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@alebedev87
Copy link
Contributor Author

alebedev87 commented Feb 26, 2024

verify-codegen fixed.

@sadasu
Copy link
Contributor

sadasu commented Feb 29, 2024

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@alebedev87 alebedev87 force-pushed the ingress-capability branch from 9990afb to 78aca51 Compare March 5, 2024 09:41
@alebedev87
Copy link
Contributor Author

alebedev87 commented Mar 5, 2024 •
edited
Loading

Merge conflict fixed.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Mar 5, 2024

/hold

Holding this PR until CVO PR is merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@alebedev87 alebedev87 force-pushed the ingress-capability branch from 78aca51 to 1f5eef6 Compare March 7, 2024 13:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@alebedev87: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-localzones 71397b2030896cdf6c403686791c07c2c6b9eb84 link false /test e2e-aws-ovn-shared-vpc-localzones
ci/prow/e2e-azure-ovn 71397b2030896cdf6c403686791c07c2c6b9eb84 link true /test e2e-azure-ovn
ci/prow/e2e-azurestack 71397b2030896cdf6c403686791c07c2c6b9eb84 link false /test e2e-azurestack
ci/prow/e2e-openstack-sdn-parallel 71397b2030896cdf6c403686791c07c2c6b9eb84 link false /test e2e-openstack-sdn-parallel
ci/prow/okd-scos-e2e-aws-ovn 71397b2030896cdf6c403686791c07c2c6b9eb84 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-fips 71397b2030896cdf6c403686791c07c2c6b9eb84 link false /test e2e-aws-ovn-fips
ci/prow/terraform-images 71397b2030896cdf6c403686791c07c2c6b9eb84 link true /test terraform-images
ci/prow/terraform-verify-vendor 71397b2030896cdf6c403686791c07c2c6b9eb84 link true /test terraform-verify-vendor
ci/prow/e2e-gcp-secureboot dfddc9b32acadae684cb196a181693c0effa99fa link false /test e2e-gcp-secureboot
ci/prow/e2e-gcp-ovn-shared-vpc dfddc9b32acadae684cb196a181693c0effa99fa link false /test e2e-gcp-ovn-shared-vpc
ci/prow/okd-e2e-aws-ovn-upgrade 1f5eef6 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Mar 7, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Mar 11, 2024

#7546 bumped the API to the latest version so this PR is not needed anymore.

@alebedev87 alebedev87 closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwsu rwsu Awaiting requested review from rwsu

1 more reviewer

@sadasu sadasu sadasu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alebedev87 @openshift-ci-robot @sadasu @openshift-merge-robot