NE-1317: manifests - add ingress capability annotation #950

alebedev87 · 2023-06-19T19:48:40Z

This PR adds the Ingress capability annotation to all the resources related to the cluster-ingress-operator: CRDS, Deployment, RBAC, CredentialsRequests.

Enhancement Proposal: openshift/enhancements#1415.
PR which added the Ingress capability to the API: openshift/api#1724.

openshift-ci-robot · 2023-06-19T19:48:43Z

@alebedev87: This pull request references NE-1317 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2023-06-20T14:11:04Z

Analysis of e2e-gcp-ovn must-gather before Ingress is known to CVO

Cluster operators: as expected - the ingress operator is not there anymore, the console and authentication operators got degraded

$ omg get co | grep -c ingress
0
$ omg get co | grep console
console                                   4.14.0-0.ci.test-2023-06-19-195548-ci-op-bp2vpk0z-latest  False      False        True      42m
$ omg get co | grep authentication
authentication                            4.14.0-0.ci.test-2023-06-19-195548-ci-op-bp2vpk0z-latest  False      False        True      44m

Namespace: no operator or operand namespaces

$ omg project openshift-ingress-operator
[ERROR] Project openshift-ingress-operator not found
$ omg project openshift-ingress
[ERROR] Project openshift-ingress not found

RBAC: no cluster roles or bindings

$ omg get clusterroles | grep -c ingress
0
$ omg get clusterrolebindings | grep -c ingress
0

CRD: DNSRecord is not there anymore, IngressController is sill there (unexpected!)

customresourcedefinitions$ \grep -ilc ingresscontroller *
ingresscontrollers.operator.openshift.io.yaml
ingresses.config.openshift.io.yaml
kubeletconfigs.machineconfiguration.openshift.io.yaml

CredentialsRequests: no credentialsrequests

$ pwd
/home/alebedev/optional-ingress/presubmit/1670881314544291840/artifacts/e2e-gcp-ovn/gather-must-gather/artifacts/registry-build04-ci-openshift-org-ci-op-bp2vpk0z-stable-sha256-47d15045bdc324349e02dc17700c1e1fa46e62ac1ac19441bc03f016b03b95e3/namespaces/openshift-cloud-credential-operator/cloudcredential.openshift.io/credentialsrequests
$ ls -l | grep -c ingress
0

CVO excluded the following C-I-O manifests due to the unrecognized capability:

excluding {0000_50_cluster-ingress-operator_00-cluster-role.yaml
excluding {0000_50_cluster-ingress-operator_00-ingress-credentials-request.yaml
excluding {0000_50_cluster-ingress-operator_00-ingress-credentials-request.yaml
excluding {0000_50_cluster-ingress-operator_00-ingress-credentials-request.yaml
excluding {0000_50_cluster-ingress-operator_00-namespace.yaml
excluding {0000_50_cluster-ingress-operator_01-cluster-role-binding.yaml
excluding {0000_50_cluster-ingress-operator_01-role-binding.yaml
excluding {0000_50_cluster-ingress-operator_01-role-binding.yaml
excluding {0000_50_cluster-ingress-operator_01-role.yaml
excluding {0000_50_cluster-ingress-operator_01-role.yaml
excluding {0000_50_cluster-ingress-operator_01-service-account.yaml
excluding {0000_50_cluster-ingress-operator_01-service.yaml
excluding {0000_50_cluster-ingress-operator_01-trusted-ca-configmap.yaml
excluding {0000_50_cluster-ingress-operator_02-deployment.yaml
excluding {0000_50_cluster-ingress-operator_03-cluster-operator.yaml
excluding {0000_90_ingress-operator_00_prometheusrole.yaml
excluding {0000_90_ingress-operator_01_prometheusrolebinding.yaml
excluding {0000_90_ingress-operator_02_servicemonitor.yaml

Interesting the absence of C-I-O CRDs, however they were called as skipped in the other log message:

Skipping customresourcedefinition "dnsrecords.ingress.operator.openshift.io" (360 of 850): unrecognized capability names: Ingress
Skipping customresourcedefinition "ingresscontrollers.operator.openshift.io" (361 of 850): unrecognized capability names: Ingress

alebedev87 · 2023-06-21T09:18:07Z

Some other jobs failed in the similar to e2e-gcp-ovn way (console and authentication operators failure): e2e-gcp-operator, e2e-aws-ovn, e2e-azure-ovn, e2e-aws-operator.

As expected e2e-aws-ovn-upgrade didn't fail because the upgraded cluster kept using the ingress operator installed in the version before this PR:

$ omg get co
NAME                                      VERSION                                                    AVAILABLE  PROGRESSING  DEGRADED  SINCE
authentication                            4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     39m
baremetal                                 4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     1h30m
cloud-controller-manager                  4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     1h33m
cloud-credential                          4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     42m
cluster-autoscaler                        4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     40m
config-operator                           4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     1h30m
console                                   4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     39m
control-plane-machine-set                 4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     6m50s
csi-snapshot-controller                   4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     10m
dns                                       4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     6m16s
etcd                                      4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     6m28s
image-registry                            4.14.0-0.ci.test-2023-06-19-200033-ci-op-bp2vpk0z-latest   True       False        False     6m47s
ingress                                   4.14.0-0.ci.test-2023-06-19-194904-ci-op-bp2vpk0z-initial  True       False        False     15m

alebedev87 · 2023-06-26T20:01:29Z

The IngressController CRD has been added by the cluster bootstrap, it was visible in the managedFields:

$ yq .metadata.managedFields[].manager ingresscontrollers.operator.openshift.io.yaml
cluster-bootstrap
kube-apiserver

According to the user defined ingress controller's installer EP:

the cluster-ingress-operator has a dedicated command to render the essential manifests (CRD and operator namespace).
the installer uses this command to apply the manifests at install time.

Miciah · 2023-07-19T15:24:01Z

Makefile

 .PHONY: crd
 crd:
-	hack/update-generated-crd.sh
+	#hack/update-generated-crd.sh


Is this needed for just the 00-custom-resource-definition.yaml and 00-custom-resource-definition-internal.yaml manifests? Would it make more sense to add the capability.openshift.io/name: Ingress annotation in openshift/api?

Yes, it would. This PR was created according to how to implement a new capability to check the CI presubmit behavior when Ingress capability is unknown. That's why I had to comment this line to not get the overrides from the api repository.
The rest of the manifests still make sense, so the PR will live on, just this comment will have to be removed once the api repository is updated.

Miciah · 2023-07-19T15:35:46Z

/assign

Miciah · 2023-07-19T15:41:03Z

As expected e2e-aws-ovn-upgrade didn't fail because the upgraded cluster kept using the ingress operator installed in the version before this PR:

Excellent!

The IngressController CRD has been added by the cluster bootstrap, it was visible in the managedFields:
$ yq .metadata.managedFields[].manager ingresscontrollers.operator.openshift.io.yaml
cluster-bootstrap
kube-apiserver

This surprises me. Which CI job does this yaml file come from?

According to the user defined ingress controller's installer EP:

* the cluster-ingress-operator has [a dedicated command to render the essential manifests](https://github.com/openshift/cluster-ingress-operator/blob/master/cmd/ingress-operator/render.go) (CRD and operator namespace).

* the installer [uses](https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template#L284-L290) this command to apply the manifests at install time.

I thought the installer only applied the IngressController CRD if it was necessary for install-time customizations. In particular, the IngressController CRD is needed for private clusters: https://github.com/openshift/installer/blob/4455542d6aa8842876016010f24d04f5eb02e7bd/pkg/asset/manifests/ingress.go#L138-L160

alebedev87 · 2023-07-19T16:33:06Z

The IngressController CRD has been added by the cluster bootstrap, it was visible in the managedFields:
$ yq .metadata.managedFields[].manager ingresscontrollers.operator.openshift.io.yaml
cluster-bootstrap
kube-apiserver
This surprises me. Which CI job does this yaml file come from?

From the must-gather of the e2e-gcp-ovn.

According to the user defined ingress controller's installer EP:
* the cluster-ingress-operator has [a dedicated command to render the essential manifests](https://github.com/openshift/cluster-ingress-operator/blob/master/cmd/ingress-operator/render.go) (CRD and operator namespace).

* the installer [uses](https://github.com/openshift/installer/blob/master/data/data/bootstrap/files/usr/local/bin/bootkube.sh.template#L284-L290) this command to apply the manifests at install time.
I thought the installer only applied the IngressController CRD if it was necessary for install-time customizations. In particular, the IngressController CRD is needed for private clusters: https://github.com/openshift/installer/blob/4455542d6aa8842876016010f24d04f5eb02e7bd/pkg/asset/manifests/ingress.go#L138-L160

Yes, that's what I found too. Does e2e-gcp-ovn job use the pre-install customizations to set the private load balancing strategy? (I doubt).

Miciah · 2023-07-19T17:19:02Z

Does e2e-gcp-ovn job use the pre-install customizations to set the private load balancing strategy? (I doubt).

I don't think it does:

The e2e-gcp-ovn job uses the "e2e-gcp-ovn" test: https://github.com/openshift/release/blob/adeb553d8bbf96071f8ea08019b9badfce78f9da/ci-operator/jobs/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master-presubmits.yaml#L585-L610
The e2e-gcp-ovn test uses the "openshift-e2e-gcp-ovn" workflow: https://github.com/openshift/release/blob/adeb553d8bbf96071f8ea08019b9badfce78f9da/ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml#L79-L83
The openshift-e2e-gcp-ovn workflow uses the typical "ipi-conf-gcp"/"ovn-conf"/"ipi-install" steps: https://github.com/openshift/release/blob/c24400caabbfc5d2333517d1bad34184e3966768/ci-operator/step-registry/openshift/e2e/gcp/ovn/openshift-e2e-gcp-ovn-workflow.yaml#L1-L18
The "ipi-conf-gcp" chain does run the ipi-conf-commands.sh script, which can set publish in the install-config if the PUBLISH environment variable is set: https://github.com/openshift/release/blob/c24400caabbfc5d2333517d1bad34184e3966768/ci-operator/step-registry/ipi/conf/ipi-conf-commands.sh#L56-L59. However, I don't see anything that sets PUBLISH in the cluster-ingress-operator configuration.
The "ovn-conf" step runs the ovn-conf-commands.sh script, which does put in some custom installer manifests, but nothing with the IngressController CRD: https://github.com/openshift/release/blob/c24400caabbfc5d2333517d1bad34184e3966768/ci-operator/step-registry/ovn/conf/ovn-conf-commands.sh

There does also exist an "ingress-gcp-glb-manifest" step that configures a private IngressController: https://github.com/openshift/release/blob/c24400caabbfc5d2333517d1bad34184e3966768/ci-operator/step-registry/ingress/gcp/glb-manifest/ingress-gcp-glb-manifest-ref.yaml. However, this step is only used in some QE tests, not in our CI jobs.

alebedev87 · 2023-07-21T14:58:41Z

The IngressController CRD has been added by the cluster bootstrap, it was visible in the managedFields:
$ yq .metadata.managedFields[].manager ingresscontrollers.operator.openshift.io.yaml
cluster-bootstrap
kube-apiserver
According to the user defined ingress controller's installer EP:

the cluster-ingress-operator has a dedicated command to render the essential manifests (CRD and operator namespace).

the installer uses this command to apply the manifests at install time.

Once the API PR is merged, the ingresscontroller CRD will have the ingress capability annotation. Therefore this repository's manifests/ will be updated too. We will have to retry the installation with None capabilityset to check whether the bootstrap will exclude the ingresscontroller CRD.

openshift-bot · 2023-10-24T01:01:09Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

alebedev87 · 2023-10-25T07:34:52Z

/remove-lifecycle stale

openshift-bot · 2024-01-23T09:00:19Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

alebedev87 · 2024-01-23T13:58:10Z

/remove-lifecycle stale

Miciah

You need to rebase. Also, please add a little more detail to the commit message. For example, I suppose you need to bump openshift/api to get the annotation in vendor/github.com/openshift/api/operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml and vendor/github.com/openshift/api/operatoringress/v1/0000_50_dns-record.yaml, which get copied into manifests/, right?

alebedev87 · 2024-02-12T22:04:13Z

@Miciah : yes, I need the API with the ingress capability. Once it's available I'll come back to this PR, there is no point in rebasing right now.

openshift-ci-robot · 2024-04-05T09:51:05Z

@alebedev87: This pull request references NE-1317 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This PR adds the Ingress capability annotation to all the resources related to the cluster-ingress-operator: CRDS, Deployment, RBAC, CredentialsRequests.

Enhancement Proposal: openshift/enhancements#1415.
PR which added the Ingress capability to the API: openshift/api#1724.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2024-04-05T12:23:30Z

/retest

alebedev87 · 2024-04-05T19:25:58Z

/test

openshift-ci · 2024-04-05T19:26:01Z

@alebedev87: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test e2e-aws-operator
/test e2e-aws-ovn
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-upgrade
/test e2e-azure-operator
/test e2e-gcp-operator
/test e2e-hypershift
/test images
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test e2e-aws-ovn-single-node
/test e2e-azure-manual-oidc
/test e2e-azure-ovn
/test e2e-gcp-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-serial
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-single-node
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-ovn
pull-ci-openshift-cluster-ingress-operator-master-e2e-hypershift
pull-ci-openshift-cluster-ingress-operator-master-images
pull-ci-openshift-cluster-ingress-operator-master-unit
pull-ci-openshift-cluster-ingress-operator-master-verify

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alebedev87 · 2024-04-05T20:17:56Z

/retest

alebedev87 · 2024-04-07T08:06:56Z

/retest

Miciah · 2024-04-12T19:08:04Z

manifests/00-ingress-credentials-request.yaml

    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
+    capability.openshift.io/name: Ingress


This manifest already has capability.openshift.io/name: CloudCredential, so you'll need to add "+Ingress" to the existing value:

Suggested change

capability.openshift.io/name: Ingress

capability.openshift.io/name: CloudCredential+Ingress

Somehow that got lost between all the rebases. Let me readd.

Miciah · 2024-04-12T19:08:22Z

manifests/00-ingress-credentials-request.yaml

    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
+    capability.openshift.io/name: Ingress


Combine the annotation value with the existing annotation.

Miciah · 2024-04-12T19:08:40Z

manifests/00-ingress-credentials-request.yaml

    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
+    capability.openshift.io/name: Ingress


Combine the annotation value with the existing annotation.

Miciah · 2024-04-12T19:15:11Z

manifests/00-cluster-role.yaml

    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
+    capability.openshift.io/name: Ingress


Where annotations are already alphabetized by key, we might as well keep things in order.

Suggested change

include.release.openshift.io/ibm-cloud-managed: "true"

include.release.openshift.io/self-managed-high-availability: "true"

include.release.openshift.io/single-node-developer: "true"

capability.openshift.io/name: Ingress

capability.openshift.io/name: Ingress

include.release.openshift.io/ibm-cloud-managed: "true"

include.release.openshift.io/self-managed-high-availability: "true"

include.release.openshift.io/single-node-developer: "true"

Ordered here and in the other manifests.

alebedev87 · 2024-04-18T13:31:57Z

Rebased after #1045 merge.

alebedev87 · 2024-04-18T16:28:05Z

/retest

Miciah · 2024-04-19T18:41:41Z

go.mod

 go 1.21

-toolchain go1.21.5
+toolchain go1.21.7


Did you mean to include this change in your PR?

Yes, this will jump depending on the env for the creator of the PR. Removed it, jut to reduce the diff.

Miciah · 2024-04-19T18:45:39Z

manifests/01-role-binding.yaml

    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
+    capability.openshift.io/name: Ingress


This list is still not in alphabetical order.

Miciah · 2024-04-19T18:45:58Z

manifests/01-role.yaml

    include.release.openshift.io/ibm-cloud-managed: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
+    capability.openshift.io/name: Ingress


Please alphabetize.

Miciah · 2024-04-19T18:47:15Z

profile-patches/ibm-cloud-managed/02-deployment.yaml.patch

  value:
    config.openshift.io/inject-proxy: ingress-operator
    include.release.openshift.io/ibm-cloud-managed: "true"
+    capability.openshift.io/name: Ingress


Please alphabetize. (It looks like the patched file is alphabetized though.)

Miciah · 2024-04-19T20:04:58Z

Thanks!
/approve
/lgtm

openshift-ci · 2024-04-19T20:09:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miciah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-04-19T21:55:45Z

@alebedev87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	`9bf38aa`	link	false	`/test e2e-aws-ovn-single-node`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2024-04-20T09:13:44Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.16.0-202404200345.p0.gbca2dff.assembly.stream.el9 for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 19, 2023

alebedev87 changed the title ~~NE-1317: manifests - adding ingress capability annotations~~ [WIP] NE-1317: manifests - adding ingress capability annotations Jun 19, 2023

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2023

openshift-ci bot requested review from Miciah and frobware June 19, 2023 19:49

Miciah reviewed Jul 19, 2023

View reviewed changes

openshift-ci bot assigned Miciah Jul 19, 2023

alebedev87 mentioned this pull request Jul 20, 2023

NE-1303: cluster version: add ingress capability openshift/api#1516

Merged

alebedev87 force-pushed the ingress-capability branch from e295e74 to 3db1f96 Compare July 25, 2023 09:55

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 24, 2023

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2023

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2023

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2024

openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2024

Miciah reviewed Feb 12, 2024

View reviewed changes

alebedev87 mentioned this pull request Mar 5, 2024

USHIFT-2089: Add router configuration options openshift/enhancements#1548

Merged

alebedev87 changed the title ~~[WIP] NE-1317: manifests - adding ingress capability annotations~~ NE-1317: manifests - adding ingress capability annotations Apr 5, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 5, 2024

alebedev87 changed the title ~~NE-1317: manifests - adding ingress capability annotations~~ NE-1317: manifests - add ingress capability annotation Apr 5, 2024

Miciah reviewed Apr 12, 2024

View reviewed changes

alebedev87 force-pushed the ingress-capability branch 2 times, most recently from 313a73a to 4ebeb77 Compare April 18, 2024 13:27

Miciah reviewed Apr 19, 2024

View reviewed changes

NE-1317: manifests - adding ingress capability annotations

9bf38aa

alebedev87 force-pushed the ingress-capability branch from 4ebeb77 to 9bf38aa Compare April 19, 2024 18:58

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024

openshift-merge-bot bot merged commit bca2dff into openshift:master Apr 19, 2024

	capability.openshift.io/name: Ingress
	capability.openshift.io/name: CloudCredential+Ingress

NE-1317: manifests - add ingress capability annotation #950

NE-1317: manifests - add ingress capability annotation #950

Uh oh!

Conversation

alebedev87 commented Jun 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jun 19, 2023 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Miciah commented Jul 19, 2023

Uh oh!

Miciah commented Jul 19, 2023

Uh oh!

alebedev87 commented Jul 19, 2023

Uh oh!

Miciah commented Jul 19, 2023

Uh oh!

alebedev87 commented Jul 21, 2023

Uh oh!

openshift-bot commented Oct 24, 2023

Uh oh!

alebedev87 commented Oct 25, 2023

Uh oh!

openshift-bot commented Jan 23, 2024

Uh oh!

alebedev87 commented Jan 23, 2024

Uh oh!

Miciah left a comment

Choose a reason for hiding this comment

Uh oh!

alebedev87 commented Feb 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 5, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Apr 5, 2024

Uh oh!

alebedev87 commented Apr 5, 2024

Uh oh!

openshift-ci bot commented Apr 5, 2024

Uh oh!

alebedev87 commented Apr 5, 2024

Uh oh!

alebedev87 commented Apr 7, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alebedev87 commented Apr 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

alebedev87 commented Jun 19, 2023 •

edited

Loading

openshift-ci-robot commented Jun 19, 2023 •

edited by openshift-ci bot

Loading

alebedev87 commented Jun 20, 2023 •

edited

Loading

alebedev87 commented Jun 21, 2023 •

edited

Loading

alebedev87 commented Jun 26, 2023 •

edited

Loading

alebedev87 commented Feb 12, 2024 •

edited

Loading

openshift-ci-robot commented Apr 5, 2024 •

edited by openshift-ci bot

Loading

alebedev87 commented Apr 18, 2024 •

edited

Loading