Skip to content

NE-1303: cluster version: add ingress capability #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 24, 2023
Merged

NE-1303: cluster version: add ingress capability #1516

openshift-merge-robot merged 1 commit into from
Jul 24, 2023

Conversation

@alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Jul 4, 2023 •
edited
Loading

Enhancement Proposal: openshift/enhancements#1415.

This PR introduces a new Ingress cluster capability which allows to enable or disable the default ingress of the OpenShift cluster: the cluster ingress operator and its custom resources. As of now the Ingress capability is added to 4.14 capabilityset. This is a subject to change if the underlying epic changes the target version.
Also, 2 CRDs managed by the cluster ingress operator are annotated with Ingress capability: IngressController, DNSRecord.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

Hello @alebedev87! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 4, 2023
@openshift-ci openshift-ci bot requested review from Miciah and mfojtik July 4, 2023 22:03
@alebedev87 alebedev87 force-pushed the ingress-capability branch 3 times, most recently from 68f9c56 to 66653ad Compare July 5, 2023 08:25
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@alebedev87 alebedev87 force-pushed the ingress-capability branch from 66653ad to 82239db Compare July 5, 2023 08:59
@alebedev87 alebedev87 changed the title [WIP] cluster version: add ingress capability cluster version: add ingress capability Jul 5, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@alebedev87 alebedev87 changed the title cluster version: add ingress capability [NE-1303] cluster version: add ingress capability Jul 5, 2023
@Miciah
Copy link
Contributor

Miciah commented Jul 19, 2023

I had a question on the operator PR about whether the capability.openshift.io/name: Ingress should be added in the openshift/api PR: https://github.com/openshift/cluster-ingress-operator/pull/950/files#r1268238815

@Miciah
Copy link
Contributor

Miciah commented Jul 19, 2023

/assign

@alebedev87 alebedev87 changed the title [NE-1303] cluster version: add ingress capability NE-1303: cluster version: add ingress capability Jul 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2023 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1303 which is a valid jira issue.

Details

In response to this:

Epic: https://issues.redhat.com/browse/NE-1129
EP: openshift/enhancements#1415

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 19, 2023 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1303 which is a valid jira issue.

Details

In response to this:

Enhancement Proposal: openshift/enhancements#1415.

This PR introduces a new Ingress cluster capability which allows to enable or disable the default ingress of the OpenShift cluster: the cluster ingress operator and its custom resources. As of now the Ingress capability is added to 4.14 capabilityset. This is a subject to change if the underlying epic changes the target version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor Author

alebedev87 commented Jul 20, 2023

@Miciah : you are right. The ingress manifests should be updated in this repository. I created openshift/cluster-ingress-operator#950 according to how to implement a new capability to check the behavior of the CI presubmit jobs when Ingress capability is unknown. The same instructions misled me with an example which didn't need CRD updates in the api repository.

@alebedev87
cluster version: add ingress capability
ee31fd8 
operator v1: annotate ingresscontroller with ingress capability
operatoringress v1: annotate dnsrecord with ingress capability
@alebedev87 alebedev87 force-pushed the ingress-capability branch from 82239db to ee31fd8 Compare July 20, 2023 22:09
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2023 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1303 which is a valid jira issue.

Details

In response to this:

Enhancement Proposal: openshift/enhancements#1415.

This PR introduces a new Ingress cluster capability which allows to enable or disable the default ingress of the OpenShift cluster: the cluster ingress operator and its custom resources. As of now the Ingress capability is added to 4.14 capabilityset. This is a subject to change if the underlying epic changes the target version.
Also, 2 CRDs managed by the cluster ingress operator are annotated with Ingress capability.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 20, 2023 •
edited by openshift-ci bot
Loading

@alebedev87: This pull request references NE-1303 which is a valid jira issue.

Details

In response to this:

Enhancement Proposal: openshift/enhancements#1415.

This PR introduces a new Ingress cluster capability which allows to enable or disable the default ingress of the OpenShift cluster: the cluster ingress operator and its custom resources. As of now the Ingress capability is added to 4.14 capabilityset. This is a subject to change if the underlying epic changes the target version.
Also, 2 CRDs managed by the cluster ingress operator are annotated with Ingress capability: IngressController, DNSRecord.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor

Miciah commented Jul 20, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2023

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alebedev87 alebedev87 mentioned this pull request Jul 21, 2023
Merged
@bparees
Copy link
Contributor

bparees commented Jul 24, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, bparees, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@openshift-merge-robot openshift-merge-robot merged commit cce4489 into openshift:master Jul 24, 2023
@alebedev87 alebedev87 mentioned this pull request Aug 2, 2023
Merged
@alebedev87 alebedev87 mentioned this pull request Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@Miciah Miciah Awaiting requested review from Miciah

Assignees

@Miciah Miciah

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alebedev87 @Miciah @openshift-ci-robot @bparees @openshift-merge-robot