-
Notifications
You must be signed in to change notification settings - Fork 584
NE-1303: Revert "cluster version: add ingress capability" #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NE-1303: Revert "cluster version: add ingress capability" #1540
Conversation
This reverts commit ee31fd8.
|
Hello @alebedev87! Some important instructions when contributing to openshift/api: |
|
@alebedev87: This pull request references NE-1303 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@alebedev87: This pull request references NE-1303 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
As the reviewers of the initial PR. |
|
does this need to be coordinated w/ reverting any other changes? in particular i'm thinking about the logic that added "ingress" as a required-capability argument to the CVO. I don't want to create a situation where something tries to reference the "ingress" cap but it's no longer considered a valid cap name. |
|
@bparees I'm trying to find a slack reference, but wanted to call your attention to @alebedev87 's description:
|
|
this is one of the PRs i was thinking of, looks like it was not yet merged and is currently held so we're probably ok: |
|
@bparees Yep, that has been deferred to 4.15. And @alebedev87 's 😃 |
Only the API PR was merged, all the other PRs for the ingress capability (including the CVO one) are on hold or WIP. |
|
thanks /approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, bparees, candita The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This reverts commit ee31fd8.
The ingress capability has been deferred to OCP 4.15. Reverting the API change to not rush on the changes in the other repositories (cvo, installer, console operator).