Skip to content

Conversation

@alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Jul 31, 2023

This reverts commit ee31fd8.

The ingress capability has been deferred to OCP 4.15. Reverting the API change to not rush on the changes in the other repositories (cvo, installer, console operator).

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

Hello @alebedev87! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 31, 2023
@openshift-ci openshift-ci bot requested review from eparis and knobunc July 31, 2023 18:58
@alebedev87 alebedev87 changed the title Revert "cluster version: add ingress capability" NE-1303: Revert "cluster version: add ingress capability" Jul 31, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023

@alebedev87: This pull request references NE-1303 which is a valid jira issue.

Details

In response to this:

This reverts commit ee31fd8.

The ingress capability has been deferred to OCP 4.15. Reverting the API change to not rush with the changes in the other repositories (cvo, installer, console operator).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 31, 2023

@alebedev87: This pull request references NE-1303 which is a valid jira issue.

Details

In response to this:

This reverts commit ee31fd8.

The ingress capability has been deferred to OCP 4.15. Reverting the API change to not rush on the changes in the other repositories (cvo, installer, console operator).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor Author

/assign @Miciah, @bparees

As the reviewers of the initial PR.

@bparees
Copy link
Contributor

bparees commented Aug 2, 2023

does this need to be coordinated w/ reverting any other changes? in particular i'm thinking about the logic that added "ingress" as a required-capability argument to the CVO. I don't want to create a situation where something tries to reference the "ingress" cap but it's no longer considered a valid cap name.

@candita
Copy link
Contributor

candita commented Aug 2, 2023

@bparees I'm trying to find a slack reference, but wanted to call your attention to @alebedev87 's description:

Reverting the API change to not rush on the changes in the other repositories (cvo, installer, console operator).

@bparees
Copy link
Contributor

bparees commented Aug 2, 2023

this is one of the PRs i was thinking of, looks like it was not yet merged and is currently held so we're probably ok:
openshift/cluster-version-operator#946

@candita
Copy link
Contributor

candita commented Aug 2, 2023

@bparees Yep, that has been deferred to 4.15. And @alebedev87 's 😃
openshift/cluster-version-operator#946 (comment)

@alebedev87
Copy link
Contributor Author

does this need to be coordinated w/ reverting any other changes? in particular i'm thinking about the logic that added "ingress" as a required-capability argument to the CVO.

Only the API PR was merged, all the other PRs for the ingress capability (including the CVO one) are on hold or WIP.

@bparees
Copy link
Contributor

bparees commented Aug 2, 2023

thanks

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2023
@candita
Copy link
Contributor

candita commented Aug 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, bparees, candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 2, 2023

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ec73741 into openshift:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants