Automator: merge upstream changes to openshift-service-mesh/sail-operator@main#341
Merged
openshift-merge-bot[bot] merged 35 commits intoopenshift-service-mesh:mainfrom Jun 18, 2025
Conversation
…m#853) * Add misspell to do basic spell validation in our docs Signed-off-by: Francisco H <frherrer@redhat.com> * Fix misspell on misspell version Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com>
Refactor the tests to run all tags on a single cluster without redeploying it. After each tag the cluster is cleaned back to its original state. Dual stack tests are still being run in their own cluster, as it needs to be deployed in dual stack mode to support it. Fixes: istio-ecosystem#827 Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot
force-pushed
the
none-main-merge_upstream_main-38a843ce
branch
from
d49821c to
0ca2f5d
Compare
openshift-service-mesh-bot
force-pushed
the
none-main-merge_upstream_main-38a843ce
branch
3 times, most recently
from
e06fed0 to
7d218ab
Compare
Using this flag allows debugging the failed test on the environment, instead of destroying it. The default behavior is still to clean up the cluster when failing. Fixes: istio-ecosystem#675 Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
openshift-service-mesh-bot
force-pushed
the
none-main-merge_upstream_main-38a843ce
branch
2 times, most recently
from
85fccbc to
4fd383e
Compare
When using `KEEP_ON_FAILURE=true` also set `SKIP_CLEANUP=true`. This keeps the cluster running after the tests, without a need to defined our own trap logic. The downside is that the cluster will keep running even if the tests passed, but seeing as using the `KEEP_ON_FAILURE` flag is excpected mainly when there are failures, it seems that it's resonable to do. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
openshift-service-mesh-bot
force-pushed
the
none-main-merge_upstream_main-38a843ce
branch
from
4fd383e to
8bee967
Compare
…used in community-operators-prod (istio-ecosystem#854) Adds new PREVIOUS_VERSION variable to the Makefile - see the comment for details Also: - Disables nightly releases for 1.0 version - Removes redundant parameters from release GH workflow and github-workflow make target - Removes extra white spaces in the nightly version string - Use VERSION as a default value for the bundle-publish make target Signed-off-by: Filip Brychta <fbrychta@redhat.com>
openshift-service-mesh-bot
force-pushed
the
none-main-merge_upstream_main-38a843ce
branch
11 times, most recently
from
d8aeb50 to
a969b08
Compare
openshift-service-mesh-bot
force-pushed
the
none-main-merge_upstream_main-38a843ce
branch
5 times, most recently
from
7d33def to
7e91754
Compare
|
lint failure should be fixed by #346 |
|
/test ocp-4.18-e2e-ocp |
Now that we have `Cleaner` clean up after each test, it makes sense to run this logic once in the suite, rather than after each test (which cleans up its own resources). Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
|
/test ocp-4.18-lint |
Message example before fix: `STEP: Waiting for resources to be deletedon cluster=primary` Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
|
/retest |
When setting up with kind, only annotate the clusters we set up. Fixes: istio-ecosystem#901 Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
We already use the same setting in e2e tests Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
|
/retest |
Collaborator
|
This PR aims to solve the issue with the helm install |
Seems that this was missed in a recent refactor, so making sure the suite skips cleaning up when it failed and we want to keep the env. Use `ReportAfterSuite` which recieves a concentrated report and can tell if the suite has passed or failed. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Francisco H <frherrer@redhat.com>
The cleanup effectively ignored the `KEEP_ON_FAILURE` flag since `CurrentSpecReport()` at this level doesn't return any usable information since all the tests have finished. Instead, we use `ReportAfterSuite` which recieves a concentrated report and can tell if the suite has passed or failed. Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
…service-mesh#582)" (istio-ecosystem#905) This reverts commit c282873. Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Collaborator
|
It will be solved by this PR |
- Fix docs for "broken_links" workflow - Fix docs with non working links - Add "workflow_dispatch" for workflow manual execution Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
* e2e allow to build and push setting target arch Signed-off-by: Francisco H <frherrer@redhat.com> * Update documentation to add TARGET_ARCH=amd64 GINKGO_FLAGS=-v make test.e2e.ocp Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com>
…stem#914) * Fix helm issue during e2e test run operator installation Signed-off-by: Francisco H <frherrer@redhat.com> Fix command error Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Improves from code review Signed-off-by: Francisco H <frherrer@redhat.com> * Update comment in build and push script Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
Signed-off-by: Maxim Babushkin <mbabushk@redhat.com>
In this test the secret generation sometimes is attempted before everything is ready, leading to flaky, hard to debug, failures. Using `Eventually` to generate the secret avoids these failures. Fixes: istio-ecosystem#866 Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>
* Change the way doc examples are created and executed Signed-off-by: Francisco H <frherrer@redhat.com> * Add the remove of the files in a trap Signed-off-by: Francisco H <frherrer@redhat.com> * Update test.docs to be able to run specific doc tag Signed-off-by: Francisco H <frherrer@redhat.com> * Update documentation to add how to run the specific test Signed-off-by: Francisco H <frherrer@redhat.com> * Update from review Signed-off-by: Francisco H <frherrer@redhat.com> * Improve test dir from review Signed-off-by: Francisco H <frherrer@redhat.com> * Fix error while running on temp dir Signed-off-by: Francisco H <frherrer@redhat.com> * Fix lint Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Mike Kolesnik <mkolesni@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Fix from review Signed-off-by: Francisco H <frherrer@redhat.com> * Fix lint Signed-off-by: Francisco H <frherrer@redhat.com> * Changes from review: update TEST_DIR var Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Mike Kolesnik <mkolesni@redhat.com>
* Update VERSIONS_YAML_FILE e2e test information Signed-off-by: Francisco H <frherrer@redhat.com> * Apply suggestions from code review Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com> Signed-off-by: Francisco H <frherrer@redhat.com> * Update read me from comments Signed-off-by: Francisco H <frherrer@redhat.com> --------- Signed-off-by: Francisco H <frherrer@redhat.com> Co-authored-by: Sridhar Gaddam <sgaddam@redhat.com>
* upstream/main: (34 commits) Update VERSIONS_YAML_FILE e2e test information (istio-ecosystem#916) Improve automated docs test run (istio-ecosystem#894) Use `Eventually` in remote secret generation (istio-ecosystem#921) Docs followup link fix (istio-ecosystem#919) Fix helm issue during e2e test run operator installation (istio-ecosystem#914) e2e allow to build and push setting target arch (istio-ecosystem#913) Fix docs for "broken_links" workflow (istio-ecosystem#918) Revert "Disable imageDigest support in ztunnel controller (openshift-service-mesh#582)" (istio-ecosystem#905) Fix typo in the ReportAfterSuite text (istio-ecosystem#911) Fix cleanup in multicluster tests (istio-ecosystem#909) Adding Eventually to Helm operator install (istio-ecosystem#907) Skip cleanup if control plane tests fail (istio-ecosystem#910) Use debug logging in integration tests (istio-ecosystem#906) Annotate only our clusters when using kind (istio-ecosystem#904) Fix log message for cleaner when waiting (istio-ecosystem#903) Consolidate multicluster operator deploy/cleanup (istio-ecosystem#902) Improve e2e test cleanup by recording & cleaning up (istio-ecosystem#889) Enchance debug information when e2e fails: add istioctl proxy status (istio-ecosystem#891) Update github action for broken links (istio-ecosystem#888) Fix "Check broken link" workflow (istio-ecosystem#887) ...
Collaborator
|
/test ocp-4.18-lint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated by Automator - 2025-06-18T15:17:33+00:00