Skip to content

[release-v1.9] Send namespace header in MT components#265

Merged
openshift-merge-robot merged 3 commits intoopenshift-knative:release-v1.9from
pierDipi:f5b1b124c233156a04b32f179b39510c6bec4a03-v1.9
Jul 6, 2023
Merged

[release-v1.9] Send namespace header in MT components#265
openshift-merge-robot merged 3 commits intoopenshift-knative:release-v1.9from
pierDipi:f5b1b124c233156a04b32f179b39510c6bec4a03-v1.9

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Jul 6, 2023 •
edited
Loading

Cherry-pick of a4d2682 and f0d6382

Send namespace header in MT components needs the PingSource adapter client creation refactoring

pierDipi added 2 commits July 6, 2023 10:06
@pierDipi
Refactor PingSource adapter client creation (knative#6880)
f0d6382 
This is just a refactoring to make it easier to implement Eventing TLS

Part of knative#6879

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Send namespace header in MT components (knative#7048)
a4d2682 
When running MT components [1] in mesh mode with Istio,
we lose the ability to define fine grained policies since we
don't know the resource namespace that originated such
request, therefore, by having a `Kn-Namespace` header,
in mesh mode, users case define fine-grained policies and
isolate namespaces.

[1] IMC, MTChannelBasedBroker, and PingSource

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested review from lberk and matzew July 6, 2023 08:18
@openshift-ci openshift-ci bot added the approved label Jul 6, 2023
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 6, 2023

/cc @creydr

@openshift-ci openshift-ci bot requested a review from creydr July 6, 2023 08:19
@pierDipi
Fix compile error
e80ec6d 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 6, 2023

/cherry-pick release-v1.10

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 6, 2023

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 6, 2023 

invalid value "1.19" for flag -compat: maximum supported Go version is 1.18
usage: go mod tidy [-e] [-v] [-go=version] [-compat=version]
Run 'go help mod tidy' for details.
make[1]: *** [generated-files] Error 2

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 6, 2023 

invalid value "1.19" for flag -compat: maximum supported Go version is 1.18
usage: go mod tidy [-e] [-v] [-go=version] [-compat=version]
Run 'go help mod tidy' for details.
make[1]: *** [generated-files] Error 2

I think we might need to bump to Go 1.19

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 6, 2023

Maybe it will be fixed by #266

@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 6, 2023

/retest-required

creydr
creydr approved these changes Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 6, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bc30bfe into openshift-knative:release-v1.9 Jul 6, 2023
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Jul 6, 2023

@pierDipi: #265 failed to apply on top of branch "release-v1.10":

Applying: Refactor PingSource adapter client creation (#6880)
Using index info to reconstruct a base tree...
M	pkg/adapter/v2/cloudevents.go
M	pkg/adapter/v2/cloudevents_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/adapter/v2/cloudevents_test.go
CONFLICT (content): Merge conflict in pkg/adapter/v2/cloudevents_test.go
Auto-merging pkg/adapter/v2/cloudevents.go
CONFLICT (content): Merge conflict in pkg/adapter/v2/cloudevents.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Refactor PingSource adapter client creation (#6880)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi pierDipi mentioned this pull request Jul 20, 2023
Merged
openshift-merge-robot pushed a commit that referenced this pull request Jul 20, 2023
@pierDipi
[release-v1.9] Send namespace header in MT components (#265) (#278)
1eb2f7a 
* Refactor PingSource adapter client creation (knative#6880)

This is just a refactoring to make it easier to implement Eventing TLS

Part of knative#6879

---------



* Send namespace header in MT components (knative#7048)

When running MT components [1] in mesh mode with Istio,
we lose the ability to define fine grained policies since we
don't know the resource namespace that originated such
request, therefore, by having a `Kn-Namespace` header,
in mesh mode, users case define fine-grained policies and
isolate namespaces.

[1] IMC, MTChannelBasedBroker, and PingSource



* Fix compile error



---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@creydr creydr mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@creydr creydr creydr approved these changes

@lberk lberk Awaiting requested review from lberk

@matzew matzew Awaiting requested review from matzew

Assignees

@creydr creydr

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierDipi @openshift-cherrypick-robot @creydr @openshift-merge-robot