Skip to content

[release-v1.9] Bump to Go 1.19#266

Merged
pierDipi merged 1 commit intoopenshift-knative:release-v1.9from
pierDipi:upgrade-to-go-1.9
Jul 6, 2023
Merged

[release-v1.9] Bump to Go 1.19#266
pierDipi merged 1 commit intoopenshift-knative:release-v1.9from
pierDipi:upgrade-to-go-1.9

Conversation

@pierDipi
Copy link
Copy Markdown
Member

@pierDipi pierDipi commented Jul 6, 2023

As per title

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

pierDipi commented Jul 6, 2023

The build image update will only be reflected once merged so we might need to force merge

Copy link
Copy Markdown
Collaborator

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question. Otherwise lgtm

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was the vendor folder updated in this PR?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make generate-release did it, I guess 1.8 is wrong as well

Copy link
Copy Markdown
Collaborator

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 6, 2023

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/412-test-reconciler-aws-ocp-412 f54918e link true /test 412-test-reconciler-aws-ocp-412
ci/prow/410-test-conformance-aws-ocp-410 f54918e link true /test 410-test-conformance-aws-ocp-410
ci/prow/412-test-e2e-aws-ocp-412 f54918e link true /test 412-test-e2e-aws-ocp-412
ci/prow/410-test-reconciler-aws-ocp-410 f54918e link true /test 410-test-reconciler-aws-ocp-410
ci/prow/412-test-conformance-aws-ocp-412 f54918e link true /test 412-test-conformance-aws-ocp-412
ci/prow/410-test-e2e-aws-ocp-410 f54918e link true /test 410-test-e2e-aws-ocp-410

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi pierDipi merged commit 222c16d into openshift-knative:release-v1.9 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants