Skip to content

[release-v1.10] Send namespace header in MT components (#265)#278

Merged
openshift-merge-robot merged 1 commit intoopenshift-knative:release-v1.10from
pierDipi:cp-bc30bfef5c899896238b54b49076f8599feb6d43-v1.10
Jul 20, 2023
Merged

[release-v1.10] Send namespace header in MT components (#265)#278
openshift-merge-robot merged 1 commit intoopenshift-knative:release-v1.10from
pierDipi:cp-bc30bfef5c899896238b54b49076f8599feb6d43-v1.10

Conversation

@pierDipi
Copy link
Copy Markdown
Member

Cherry-pick of #265

* Refactor PingSource adapter client creation (knative#6880)

This is just a refactoring to make it easier to implement Eventing TLS

Part of knative#6879

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Send namespace header in MT components (knative#7048)

When running MT components [1] in mesh mode with Istio,
we lose the ability to define fine grained policies since we
don't know the resource namespace that originated such
request, therefore, by having a `Kn-Namespace` header,
in mesh mode, users case define fine-grained policies and
isolate namespaces.

[1] IMC, MTChannelBasedBroker, and PingSource

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Fix compile error

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

/assign @matzew @creydr

@openshift-ci openshift-ci bot requested review from creydr and matzew July 20, 2023 10:47
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 20, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1eb2f7a into openshift-knative:release-v1.10 Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants