Bump all Knative go-deps to version 1.10 by ReToCode · Pull Request #2207 · openshift-knative/serverless-operator

ReToCode · 2023-08-03T07:53:56Z

Proposed Changes

Bump all Knative go-deps to version 1.10
Update hack/patches/005-conversion-webhook.patch to reflect changes in 1.10
Drop hack/patches/013-rekt-test-add-service-port-name.patch because it is already in 1.10
Update hack/patches/remove_eventing_ns_manifest.patch to reflect changes in 1.10
Use subdir for ingress manifests based on Change file structure for ingresses knative/operator#1355

ReToCode · 2023-08-03T07:56:18Z

@pierDipi @matzew are the to patches for Eventing ok like this? Outcome: https://github.com/openshift-knative/serverless-operator/pull/2207/files#diff-426607a57d59b8ed0160ad85ad91a1edf983acb570ce2f4f57a624c07e8c41f5R27 and https://github.com/openshift-knative/serverless-operator/pull/2207/files#diff-b970ddcc07cde675e0aa5e5d6e107c3f29882ab7a8f6ecb840debebacc512b45R25

@skonto @nak3 are webhook patches ok like this? Outcome: https://github.com/openshift-knative/serverless-operator/pull/2207/files#diff-4ade17300ba49da3fe4bcf7ff0e67471ae89f4938d3d926895c0efaa7943c41bR44

ReToCode · 2023-08-03T08:08:09Z

@pierDipi Hm, this does not work anymore, as Addressable with CACerts is no longer assignable to URL.

nak3 · 2023-08-03T08:10:51Z

@skonto @nak3 are webhook patches ok like this? Outcome: https://github.com/openshift-knative/serverless-operator/pull/2207/files#diff-4ade17300ba49da3fe4bcf7ff0e67471ae89f4938d3d926895c0efaa7943c41bR44

Okay to me but I guess Stavros is working on #2148 so defer to him.

go.mod

ReToCode · 2023-08-04T07:28:34Z

error=Get "https://10.0.128.94:10250/containerLogs/ci-op-p6d50wjt/upstream-e2e-aws-ocp-413-serverless-e2e/test": x509: certificate signed by unknown authority

/retest

ReToCode · 2023-08-04T07:45:45Z

/retest

ReToCode · 2023-08-07T05:03:31Z

/retest

ReToCode · 2023-08-07T09:07:15Z

/retest

matzew · 2023-08-07T13:57:15Z

vendor/knative.dev/eventing/test/rekt/resources/containersource/containersource.yaml

@@ -49,7 +49,7 @@ spec:
    spec:
      containers:
      - name: heartbeats
-        image: registry.ci.openshift.org/openshift/knative-v1.8:knative-eventing-test-heartbeats
+        image: ko://knative.dev/eventing/cmd/heartbeats


that's a wrong reference here, we don't do the ko:// this should be proper in midstream....

matzew · 2023-08-08T11:36:03Z

In the job:
pull-ci-openshift-knative-serverless-operator-main-4.13-operator-e2e-aws-ocp-413

I see:

  - Match errors -
        0 - Kn-Namespace header not found
        1 - Kn-Namespace header not found
        2 - Kn-Namespace header not found
        3 - Kn-Namespace header not found

https://prow.ci.openshift.org/log?container=test&id=1688863651936604160&job=pull-ci-openshift-knative-serverless-operator-main-4.13-operator-e2e-aws-ocp-413

matzew · 2023-08-08T12:00:54Z

@mgencur is that above Kn-Namespace related to this?
#2195

(or some env var, for "istio" (or not istio)?

matzew · 2023-08-08T12:24:25Z

/test 4.13-upstream-e2e-kafka-aws-ocp-413

mgencur · 2023-08-08T12:40:07Z

@mgencur is that above Kn-Namespace related to this?
#2195

I don't think it's related. The test is obviously updated in this PR so it expects the KnHeader. All the other tests are passing (channel-related ones etc. which expect the KnHeader as well). So, the Knative Forwarder component should be forwarding the header correctly. I also checked the image of Ping source adapter and it's version 1.10 which is OK.
I don't know why this error happens.

mgencur · 2023-08-08T12:47:15Z

@matzew I'd probably try to remove this line to see if the problem is in the forwarder. If the test passes the problem is in forwarder, if it still fails it must be in PingSource.

creydr · 2023-08-08T13:38:06Z

In the PingSource we add since 1.9 the Kn-Namespace header (openshift-knative/eventing#265). Not sure, if this header gets forwarded in the forwarder too

ReToCode · 2023-08-09T07:14:07Z

Trying without the forwarder to see if this is the issue.

/hold

matzew · 2023-08-09T07:56:44Z

+++ b/go.mod
@@ -184,8 +184,8 @@ replace (
 	knative.dev/eventing-kafka-broker => github.com/openshift-knative/eventing-kafka-broker v0.25.1-0.20230803130431-bf8f4e608e85
 	knative.dev/hack => knative.dev/hack v0.0.0-20230417170854-f591fea109b3
 	knative.dev/networking => knative.dev/networking v0.0.0-20230419144338-e5d04e805e50
- 	knative.dev/reconciler-test => knative.dev/reconciler-test v0.0.0-202[30](https://github.com/openshift-knative/serverless-operator/actions/runs/5806025450/job/15738118955?pr=2207#step:10:31)808072333-158379f56e0b
 	knative.dev/pkg => knative.dev/pkg v0.0.0-20230418073056-dfad48eaa5d0
+	knative.dev/reconciler-test => knative.dev/reconciler-test v0.0.0-20230808072333-158379f56e0b
 	knative.dev/serving => github.com/openshift-knative/serving v0.10.1-0.20230721070749-1af735104[33](https://github.com/openshift-knative/serverless-operator/actions/runs/5806025450/job/15738118955?pr=2207#step:10:34)0
 )

mgencur · 2023-08-09T08:30:20Z

OK. So it seems the issue is in forwarder...

mgencur · 2023-08-09T08:39:19Z

Yeah. Looking at the logs from the forwarder:

Received event:

{"level":"info","ts":"2023-08-08T11:29:00.203Z","logger":"eventshub.event logger","caller":"logger_vent/logger.go:26","msg":"Event: \n-- EventInfo --\n--- Kind: Received ---\n--- Event ---\nContext Attributes,\n  specversion: 1.0\n  type: dev.knative.sources.ping\n  source: /apis/v1/namespaces/test-znrhfwtv/pingsources/pingsource-hdicxhyy\n  id: 7edb6ea3-31ea-4dbb-a5d6-62aaa9ea5bff\n  time: 2023-08-08T11:29:00.081538462Z\n\n--- HTTP headers ---\n  X-Request-Id: 56a28edf-d5bb-4e49-bd1c-9a0dd08b9b1b\n  X-B3-Spanid: d0d1dcc37b90469a\n  X-B3-Traceid: d626695bb5c8ad09af015327faa16bb3\n  K-Proxy-Request: activator\n  X-B3-Sampled: 1\n  User-Agent: Go-http-client/1.1\n  Host: sink-bvacvnzb.test-znrhfwtv.svc.cluster.local\n  Content-Length: 0\n  Traceparent: 00-d626695bb5c8ad09af015327faa16bb3-d0d1dcc37b90469a-01\n  Accept-Encoding: gzip\n  Kn-Namespace: test-znrhfwtv\n  X-Forwarded-Proto: http\n  Forwarded: for=10.131.0.23;proto=http\n  X-Forwarded-For: 10.131.0.23, 10.129.2.23\n\n--- Origin: '127.0.0.1:44260' ---\n--- Observer: 'sink-bvacvnzb' ---\n--- Time: 2023-08-08 11:29:00.203898196 +0000 UTC m=+106.857147156 ---\n--- Sequence: 0 ---\n--- Sent Id:  ' ---\n--------------------\n"}

Sent/forwarded event:

{"level":"info","ts":"2023-08-08T11:29:00.212Z","logger":"eventshub.event logger","caller":"logger_vent/logger.go:26","msg":"Event: \n-- EventInfo --\n--- Kind: Sent ---\n--- Event ---\nContext Attributes,\n  specversion: 1.0\n  type: dev.knative.sources.ping\n  source: /apis/v1/namespaces/test-znrhfwtv/pingsources/pingsource-hdicxhyy\n  id: 7edb6ea3-31ea-4dbb-a5d6-62aaa9ea5bff\n  time: 2023-08-08T11:29:00.081538462Z\n\n--- HTTP headers ---\n  Ce-Id: 7edb6ea3-31ea-4dbb-a5d6-62aaa9ea5bff\n  Ce-Source: /apis/v1/namespaces/test-znrhfwtv/pingsources/pingsource-hdicxhyy\n  Ce-Specversion: 1.0\n  Ce-Type: dev.knative.sources.ping\n  Ce-Time: 2023-08-08T11:29:00.081538462Z\n\n--- Origin: 'sink-bvacvnzb' ---\n--- Observer: 'sink-bvacvnzb' ---\n--- Time: 2023-08-08 11:29:00.212682216 +0000 UTC m=+106.865931174 ---\n--- Sequence: 0 ---\n--- Sent Id:  '7edb6ea3-31ea-4dbb-a5d6-62aaa9ea5bff ---\n--------------------\n"}

The kn-namespace header is not forwarded.

mgencur · 2023-08-09T08:55:34Z

I will work on the fix for the forwarder.

mgencur · 2023-08-09T09:43:07Z

Would this be acceptable? knative-extensions/reconciler-test#572
I still need to test it with real deployment but I think it should work.

ReToCode · 2023-08-09T10:10:49Z

Would this be acceptable? knative-extensions/reconciler-test#572

Deferring this to Eventing folks @matzew , @creydr . Just out of curiosity, is there a specific reason the forwarder filters headers in the first place?

mgencur · 2023-08-09T10:15:24Z

Deferring this to Eventing folks. Just out of curiosity, is there a specific reason the forwarder filters headers in the first place?

No specific reason. Forwarding of headers was just not implemented, probably by mistake.

matzew · 2023-08-09T10:41:25Z

No specific reason. Forwarding of headers was just not implemented, probably by mistake.

should it just be transparent? forward, as is - and not edit/manipulate the actual req?

mgencur · 2023-08-09T13:20:58Z

Apparently, something like this works as well: knative-extensions/reconciler-test#575

mgencur · 2023-08-11T09:39:25Z

test/images-rekt.yaml

@@ -1 +1,2 @@
 knative.dev/reconciler-test/cmd/eventshub: registry.ci.openshift.org/openshift/knative-eventing-test-eventshub:knative-nightly


Is it right that you still use knative-nightly here? Should that be v1.10?
I think you said nightly cannot be used anymore. Just curious.

Not sure, I think my comments were only related to the code deps from main branch because of a conflict with the changes to Adressable upstream. We should be fine with that image (I think..., let's see).

OK. Anyway, the backports helped for multiarch builds here: 3863526
We should probably use this image as well here so that we have the multiarch image from the beginning and no need to patch later like in the commit above.
Also, the version will change with each release so we probably need to create a template for this file and generate the resulting file automatically. But this can be done in a follow-up. I'd suggest using the quay image in this file for both eventshub and heartbeats. The latest available heartbeats image at quay is v1.9 though: quay.io/openshift-knative/eventing/heartbeats:v1.9 That's because the image was moved from test images to core images in 1.10 and the github action is not building it (this needs a fix!)

Well, it's probably better to use quay images later, not in this PR. There's more work to be done. Let's keep using registry.ci in this PR.

Created https://issues.redhat.com/browse/SRVCOM-2649

matzew · 2023-08-11T10:46:17Z

/test ?

openshift-ci · 2023-08-11T10:46:21Z

@matzew: The following commands are available to trigger required jobs:

/test 4.10-images
/test 4.10-operator-e2e-aws-ocp-410
/test 4.10-ui-tests
/test 4.13-aws-ovn-images
/test 4.13-azure-images
/test 4.13-gcp-images
/test 4.13-hypershift-images
/test 4.13-images
/test 4.13-operator-e2e-aws-ocp-413
/test 4.13-osd-images
/test 4.13-single-node-images
/test 4.13-ui-tests
/test 4.13-vsphere-images
/test ocp4.14-lp-interop-images
/test unit-test

The following commands are available to trigger optional jobs:

/test 4.10-e2e-kitchensink-ocp-410
/test 4.10-upgrade-kitchensink-ocp-410
/test 4.10-upgrade-tests-aws-ocp-410
/test 4.10-upstream-e2e-aws-ocp-410
/test 4.10-upstream-e2e-kafka-aws-ocp-410
/test 4.10-upstream-e2e-mesh-aws-ocp-410
/test 4.13-e2e-kitchensink-ocp-413
/test 4.13-upgrade-kitchensink-ocp-413
/test 4.13-upgrade-tests-aws-ocp-413
/test 4.13-upstream-e2e-aws-ocp-413
/test 4.13-upstream-e2e-kafka-aws-ocp-413
/test 4.13-upstream-e2e-mesh-aws-ocp-413

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-serverless-operator-main-4.10-images
pull-ci-openshift-knative-serverless-operator-main-4.13-aws-ovn-images
pull-ci-openshift-knative-serverless-operator-main-4.13-azure-images
pull-ci-openshift-knative-serverless-operator-main-4.13-gcp-images
pull-ci-openshift-knative-serverless-operator-main-4.13-hypershift-images
pull-ci-openshift-knative-serverless-operator-main-4.13-images
pull-ci-openshift-knative-serverless-operator-main-4.13-operator-e2e-aws-ocp-413
pull-ci-openshift-knative-serverless-operator-main-4.13-osd-images
pull-ci-openshift-knative-serverless-operator-main-4.13-single-node-images
pull-ci-openshift-knative-serverless-operator-main-4.13-upgrade-tests-aws-ocp-413
pull-ci-openshift-knative-serverless-operator-main-4.13-upstream-e2e-aws-ocp-413
pull-ci-openshift-knative-serverless-operator-main-4.13-upstream-e2e-kafka-aws-ocp-413
pull-ci-openshift-knative-serverless-operator-main-4.13-vsphere-images
pull-ci-openshift-knative-serverless-operator-main-ocp4.14-lp-interop-images
pull-ci-openshift-knative-serverless-operator-main-unit-test

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

matzew · 2023-08-11T10:46:49Z

It passed. testing it again

/test 4.13-operator-e2e-aws-ocp-413

matzew

/lgtm
/approve

/hold until the mentioned e2e test passes

openshift-ci · 2023-08-11T10:47:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ReToCode,matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ReToCode · 2023-08-11T11:53:56Z

Yay 🎉

/unhold

ReToCode · 2023-08-11T12:10:05Z

/unhold

openshift-ci · 2023-08-11T15:54:57Z

/test remaining-required

openshift-ci bot requested review from alanfx and mgencur August 3, 2023 07:54

openshift-ci bot added the approved label Aug 3, 2023

openshift-ci bot requested review from matzew, pierDipi and skonto August 3, 2023 07:56

pierDipi reviewed Aug 3, 2023

View reviewed changes

go.mod Outdated Show resolved Hide resolved

ReToCode mentioned this pull request Aug 3, 2023

[release-1.10] Function CopySecretWithName for creating secrets with … openshift-knative/eventing#302

Merged

ReToCode force-pushed the bump-code-1-30 branch from b879613 to 006568e Compare August 4, 2023 09:32

ReToCode force-pushed the bump-code-1-30 branch from d1ea4ad to 6511564 Compare August 7, 2023 13:36

matzew reviewed Aug 7, 2023

View reviewed changes

openshift-merge-robot added the needs-rebase label Aug 8, 2023

ReToCode force-pushed the bump-code-1-30 branch from 25b5d87 to e32bce5 Compare August 8, 2023 10:43

openshift-merge-robot removed the needs-rebase label Aug 8, 2023

openshift-ci bot added the do-not-merge/hold label Aug 9, 2023

Bump all Knative go-deps to version 1.10

1c93def

mgencur reviewed Aug 11, 2023

View reviewed changes

ReToCode force-pushed the bump-code-1-30 branch from 728af06 to 1c93def Compare August 11, 2023 09:41

matzew approved these changes Aug 11, 2023

View reviewed changes

openshift-ci bot assigned matzew Aug 11, 2023

openshift-ci bot added the lgtm label Aug 11, 2023

openshift-ci bot removed the do-not-merge/hold label Aug 11, 2023

openshift-merge-robot merged commit 20fdaf8 into openshift-knative:main Aug 11, 2023

		@@ -1 +1,2 @@
		knative.dev/reconciler-test/cmd/eventshub: registry.ci.openshift.org/openshift/knative-eventing-test-eventshub:knative-nightly

Conversation

ReToCode commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Uh oh!

ReToCode commented Aug 3, 2023

Uh oh!

ReToCode commented Aug 3, 2023

Uh oh!

nak3 commented Aug 3, 2023

Uh oh!

Uh oh!

ReToCode commented Aug 4, 2023

Uh oh!

ReToCode commented Aug 4, 2023

Uh oh!

ReToCode commented Aug 7, 2023

Uh oh!

ReToCode commented Aug 7, 2023

Uh oh!

matzew Aug 7, 2023

Choose a reason for hiding this comment

Uh oh!

matzew commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matzew commented Aug 8, 2023

Uh oh!

matzew commented Aug 8, 2023

Uh oh!

mgencur commented Aug 8, 2023

Uh oh!

mgencur commented Aug 8, 2023

Uh oh!

creydr commented Aug 8, 2023

Uh oh!

ReToCode commented Aug 9, 2023

Uh oh!

matzew commented Aug 9, 2023

Uh oh!

mgencur commented Aug 9, 2023

Uh oh!

mgencur commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mgencur commented Aug 9, 2023

Uh oh!

mgencur commented Aug 9, 2023

Uh oh!

ReToCode commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mgencur commented Aug 9, 2023

Uh oh!

matzew commented Aug 9, 2023

Uh oh!

mgencur commented Aug 9, 2023

Uh oh!

mgencur Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

ReToCode Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

mgencur Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

mgencur Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

mgencur Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

matzew commented Aug 11, 2023

Uh oh!

openshift-ci bot commented Aug 11, 2023

Uh oh!

matzew commented Aug 11, 2023

Uh oh!

matzew left a comment

ReToCode commented Aug 3, 2023 •

edited

Loading

matzew commented Aug 8, 2023 •

edited

Loading

mgencur commented Aug 9, 2023 •

edited

Loading

ReToCode commented Aug 9, 2023 •

edited

Loading