Use SdkClient for persistence in TransportGetMonitorAction - #2053
Merged
AWSHurneyt merged 2 commits intoMar 26, 2026
Merged
Conversation
manaswini1920
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn,
sbcd90 and
toepkerd
as code owners
March 25, 2026 19:24
riysaxen-amzn
approved these changes
Mar 25, 2026
riysaxen-amzn
self-requested a review
March 25, 2026 19:35
manaswini1920
force-pushed
the
feature/sdk-persistence-refactor
branch
from
March 25, 2026 19:59
5656563 to
8d4bb0c
Compare
manaswini1920
changed the title
engechas
approved these changes
Mar 25, 2026
Replace direct client.get() with sdkClient.getDataObjectAsync() for monitor retrieval. SDK handles local vs remote routing internally. Follows ML Commons pattern (TransportRegisterAgentAction). Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
manaswini1920
force-pushed
the
feature/sdk-persistence-refactor
branch
from
March 26, 2026 05:27
8d4bb0c to
95a7bbe
Compare
Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
eirsep
approved these changes
Mar 26, 2026
AWSHurneyt
approved these changes
Mar 26, 2026
AWSHurneyt
merged commit Mar 26, 2026
9858daa
into
opensearch-project:remote-metadata-support
18 checks passed
This was referenced Mar 26, 2026
5 tasks
manaswini1920
pushed a commit
to manaswini1920/alerting
that referenced
this pull request
Apr 10, 2026
…etadata support - Migrate TransportGetMonitorAction to use SdkClient (opensearch-project#2053) - Migrate GetAlerts, DeleteComment, GetWorkflowAlerts, ExecuteMonitor to SdkClient (opensearch-project#2061) - Fix listener leak in TransportExecuteMonitorAction for empty source (opensearch-project#2080) - Migrate DeleteMonitor, GetDestinations, SearchAlertingComment, SearchMonitor to SdkClient (opensearch-project#2060) - Migrate IndexAlertingComment, IndexMonitor to SdkClient (opensearch-project#2081) - Migrate MonitorMetadataService to SdkClient (opensearch-project#2083) - Add new query level trigger evaluation independent of ScriptingService (opensearch-project#2079, opensearch-project#2090) - Migrate AlertService to SdkClient (opensearch-project#2088) - Migrate TransportAcknowledgeAlertAction to SdkClient (opensearch-project#2089) Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Apr 10, 2026
…etadata support (#2093) - Migrate TransportGetMonitorAction to use SdkClient (#2053) - Migrate GetAlerts, DeleteComment, GetWorkflowAlerts, ExecuteMonitor to SdkClient (#2061) - Fix listener leak in TransportExecuteMonitorAction for empty source (#2080) - Migrate DeleteMonitor, GetDestinations, SearchAlertingComment, SearchMonitor to SdkClient (#2060) - Migrate IndexAlertingComment, IndexMonitor to SdkClient (#2081) - Migrate MonitorMetadataService to SdkClient (#2083) - Add new query level trigger evaluation independent of ScriptingService (#2079, #2090) - Migrate AlertService to SdkClient (#2088) - Migrate TransportAcknowledgeAlertAction to SdkClient (#2089) Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com> Co-authored-by: Manaswini Ragamouni <ragamanu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace direct client.get() with sdkClient.getDataObjectAsync() for monitor retrieval.
SDK handles local vs remote routing internally based on remote_metadata_type setting.
Follows the same pattern as ML Commons (TransportRegisterAgentAction).
Reference: https://github.com/opensearch-project/ml-commons/blob/main/plugin/src/main/java/org/opensearch/ml/action/agents/TransportRegisterAgentAction.java
Related Issues
Depends on #2047, #2052
Part of #2094
Check List
--signoff.