Fix listener leak in TransportExecuteMonitorAction for empty source - #2080
Merged
engechas merged 1 commit intoApr 1, 2026
Conversation
Add else block when getResponse.isSourceEmpty is true to call actionListener.onFailure() instead of silently dropping the request. Without this, the listener is never notified and the thread hangs. Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
manaswini1920
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn,
sbcd90 and
toepkerd
as code owners
April 1, 2026 16:39
eirsep
approved these changes
Apr 1, 2026
engechas
approved these changes
Apr 1, 2026
engechas
merged commit Apr 1, 2026
1655ae2
into
opensearch-project:remote-metadata-support
19 of 23 checks passed
5 tasks
manaswini1920
pushed a commit
to manaswini1920/alerting
that referenced
this pull request
Apr 10, 2026
…etadata support - Migrate TransportGetMonitorAction to use SdkClient (opensearch-project#2053) - Migrate GetAlerts, DeleteComment, GetWorkflowAlerts, ExecuteMonitor to SdkClient (opensearch-project#2061) - Fix listener leak in TransportExecuteMonitorAction for empty source (opensearch-project#2080) - Migrate DeleteMonitor, GetDestinations, SearchAlertingComment, SearchMonitor to SdkClient (opensearch-project#2060) - Migrate IndexAlertingComment, IndexMonitor to SdkClient (opensearch-project#2081) - Migrate MonitorMetadataService to SdkClient (opensearch-project#2083) - Add new query level trigger evaluation independent of ScriptingService (opensearch-project#2079, opensearch-project#2090) - Migrate AlertService to SdkClient (opensearch-project#2088) - Migrate TransportAcknowledgeAlertAction to SdkClient (opensearch-project#2089) Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Apr 10, 2026
…etadata support (#2093) - Migrate TransportGetMonitorAction to use SdkClient (#2053) - Migrate GetAlerts, DeleteComment, GetWorkflowAlerts, ExecuteMonitor to SdkClient (#2061) - Fix listener leak in TransportExecuteMonitorAction for empty source (#2080) - Migrate DeleteMonitor, GetDestinations, SearchAlertingComment, SearchMonitor to SdkClient (#2060) - Migrate IndexAlertingComment, IndexMonitor to SdkClient (#2081) - Migrate MonitorMetadataService to SdkClient (#2083) - Add new query level trigger evaluation independent of ScriptingService (#2079, #2090) - Migrate AlertService to SdkClient (#2088) - Migrate TransportAcknowledgeAlertAction to SdkClient (#2089) Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com> Co-authored-by: Manaswini Ragamouni <ragamanu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
Description
Add else block in TransportExecuteMonitorAction when
getResponse.isSourceEmptyis true. Without this, the action listener is never notified when the monitor source is empty, causing the thread to hang indefinitely and potentially dropping nodes.Related Issues
Follow-up from #2061 (review comment from @eirsep)
Part of #2094
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.