Migrates AlertService to use SdkClient for all alert persistence operations ( - #2088
Merged
riysaxen-amzn merged 4 commits intoApr 9, 2026
Conversation
manaswini1920
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn,
sbcd90 and
toepkerd
as code owners
April 7, 2026 19:17
…back Migrate AlertService to use SdkClient for all alert persistence: - searchAlerts: SearchDataObjectRequest with routing - upsertMonitorErrorAlert: search + put via SdkClient - clearMonitorErrorAlert: search + bulk put via SdkClient - moveClearedErrorAlertsToHistory: search + bulk put via SdkClient - saveAlerts: bulk put/delete via SdkClient - saveNewAlerts: bulk put via SdkClient - deleteByQuery stays on direct client (no SDK equivalent) Address PR opensearch-project#2083 review feedback: - Move sdkClient into MonitorMetadataService.initialize() parameter - Use AlertingException.isIndexNotFoundException() from common-utils - Move sdkClient creation before AlertService in AlertingPlugin Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
manaswini1920
force-pushed
the
feature/sdk-alert-service
branch
from
April 7, 2026 19:26
272dadc to
3674b96
Compare
engechas
reviewed
Apr 7, 2026
| } | ||
|
|
||
| val bulkResponse: BulkResponse = client.suspendUntil { | ||
| bulk(BulkRequest().add(copyRequests).setRefreshPolicy(WriteRequest.RefreshPolicy.IMMEDIATE), it) |
Collaborator
There was a problem hiding this comment.
Is there a way to preserve the refresh behavior in the remote SDK?
Collaborator
Author
There was a problem hiding this comment.
Yes, refresh behavior is preserved. Both BulkDataObjectRequest and PutDataObjectRequest default to RefreshPolicy.IMMEDIATE, same as the original code. The SDK's LocalClusterIndicesClient passes the refresh policy through to the native OpenSearch BulkRequest/IndexRequest. https://github.com/opensearch-project/opensearch-remote-metadata sdk/blob/ffaff73f0c64eff1bd4d79ab42244c5315df51f2/core/src/main/java/org/opensearch/remote/metadata/client/BulkDataObjectRequest.java#L29
Collaborator
|
CIs are failing. Could you check if it's related to these changes? |
This was referenced Apr 7, 2026
Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
Merged
1 task
Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
riysaxen-amzn
approved these changes
Apr 9, 2026
engechas
approved these changes
Apr 9, 2026
riysaxen-amzn
merged commit Apr 9, 2026
13ec16f
into
opensearch-project:remote-metadata-support
19 of 23 checks passed
5 tasks
manaswini1920
pushed a commit
to manaswini1920/alerting
that referenced
this pull request
Apr 10, 2026
…etadata support - Migrate TransportGetMonitorAction to use SdkClient (opensearch-project#2053) - Migrate GetAlerts, DeleteComment, GetWorkflowAlerts, ExecuteMonitor to SdkClient (opensearch-project#2061) - Fix listener leak in TransportExecuteMonitorAction for empty source (opensearch-project#2080) - Migrate DeleteMonitor, GetDestinations, SearchAlertingComment, SearchMonitor to SdkClient (opensearch-project#2060) - Migrate IndexAlertingComment, IndexMonitor to SdkClient (opensearch-project#2081) - Migrate MonitorMetadataService to SdkClient (opensearch-project#2083) - Add new query level trigger evaluation independent of ScriptingService (opensearch-project#2079, opensearch-project#2090) - Migrate AlertService to SdkClient (opensearch-project#2088) - Migrate TransportAcknowledgeAlertAction to SdkClient (opensearch-project#2089) Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Apr 10, 2026
…etadata support (#2093) - Migrate TransportGetMonitorAction to use SdkClient (#2053) - Migrate GetAlerts, DeleteComment, GetWorkflowAlerts, ExecuteMonitor to SdkClient (#2061) - Fix listener leak in TransportExecuteMonitorAction for empty source (#2080) - Migrate DeleteMonitor, GetDestinations, SearchAlertingComment, SearchMonitor to SdkClient (#2060) - Migrate IndexAlertingComment, IndexMonitor to SdkClient (#2081) - Migrate MonitorMetadataService to SdkClient (#2083) - Add new query level trigger evaluation independent of ScriptingService (#2079, #2090) - Migrate AlertService to SdkClient (#2088) - Migrate TransportAcknowledgeAlertAction to SdkClient (#2089) Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com> Co-authored-by: Manaswini Ragamouni <ragamanu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Migrates AlertService to use SdkClient for all alert persistence operations (search, put, bulk, delete) as part of the remote metadata SDK migration for background services. Also addresses review feedback from PR #2083:
Changes:
Part of #2094
Depends on: