Inject SdkClient into transport actions for SDK persistence support - #2052
Merged
riysaxen-amzn merged 2 commits intoMar 25, 2026
Conversation
manaswini1920
requested review from
AWSHurneyt,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
jowg-amazon,
lezzago,
praveensameneni,
rishabhmaurya,
riysaxen-amzn,
sbcd90 and
toepkerd
as code owners
March 24, 2026 21:36
engechas
reviewed
Mar 24, 2026
engechas
left a comment
engechas
left a comment
Collaborator
There was a problem hiding this comment.
Could you check on the failing CIs?
manaswini1920
force-pushed
the
feature/workspace-datasource-support
branch
from
March 24, 2026 21:56
37c8f72 to
8e7a895
Compare
Collaborator
Author
Fixed the CI — added missing force declarations for jackson-dataformat-smile and jackson-dataformat-yaml in build.gradle. This was a pre-existing dependency conflict from the 3.6.0-SNAPSHOT version bump. |
manaswini1920
force-pushed
the
feature/workspace-datasource-support
branch
from
March 24, 2026 22:12
8e7a895 to
5f8545e
Compare
Add SdkClient as a constructor parameter to all transport actions that perform persistence operations. SdkClient is created by AlertingPlugin and injected via Guice. This wiring enables transport actions to use the Remote Metadata SDK for storage routing in a future change. Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
manaswini1920
force-pushed
the
feature/workspace-datasource-support
branch
from
March 24, 2026 23:28
5f8545e to
cb32b7e
Compare
Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
engechas
approved these changes
Mar 25, 2026
nishtham-amazon
approved these changes
Mar 25, 2026
riysaxen-amzn
approved these changes
Mar 25, 2026
riysaxen-amzn
merged commit Mar 25, 2026
551e26e
into
opensearch-project:main
19 of 20 checks passed
2 tasks
manaswini1920
pushed a commit
to manaswini1920/alerting
that referenced
this pull request
Mar 25, 2026
…upport (opensearch-project#2052)" This reverts commit 551e26e. Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Mar 25, 2026
* Revert "Inject SdkClient into transport actions for SDK persistence support (#2052)" This reverts commit 551e26e. Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com> * Revert "feat: Integrate remote metadata SDK client with alerting plugin (#2046) (#2047)" This reverts commit 7fae816. Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com> --------- Signed-off-by: Manaswini Ragamouni <ragamanu@amazon.com> Co-authored-by: Manaswini Ragamouni <ragamanu@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inject SdkClient into transport actions for SDK persistence support.
Related Issues
Depends on #2047
Part of #2094
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.