feat: store changes filter by start time#455
Merged
Merged
Conversation
ryanpq
marked this pull request as ready for review
November 27, 2024 20:04
ewanharris
reviewed
Dec 3, 2024
ewanharris
left a comment
ewanharris
left a comment
Member
There was a problem hiding this comment.
It looks like we're differing on how start_time is provided with some using Options (.NET, Go, Python) and others using the Request (JS, maybe Java?)
imo, we should treat start_time similar to type as it smells like a "user provided value" but we don't really have a strict definition AFAIK.
rhamzeh
changed the title
ewanharris
reviewed
Dec 11, 2024
ewanharris
reviewed
Dec 16, 2024
start_time in read changes api Update config/clients/python/template/src/sync/client/client.py.mustache Update config/clients/python/template/src/client/models/read_changes_request.py.mustache Update config/clients/python/template/src/client/models/read_changes_request.py.mustache move ReadChanges start_time to body instead of options in dotNet Update to python readme, dotNet model Readme updates for start_time in changes updates to java start_time in read changes updates to java start_time in read changes updates to java start_time in read changes updates to java start_time in read changes updates to python start_time in read changes updates to python start_time in read changes updates to python start_time in read changes updates to go start_time in read changes updates to go start_time in read changes updates to go start_time in read changes updates to go start_time in read changes Update js start_time in changes request Update js start_time in changes request Update js start_time in changes request Update js start_time in changes request Update js start_time in changes request Adding Java changes for start time on read changes dotnet client options error fix read changes start_time WIP (dotnet) changes start_time for python changes start_time in js WIP changes start_time for go WIP dotNet start_time in read changes WIP Co-Authored-By: Ewan Harris <ewan.harris@okta.com>
ryanpq
force-pushed
the
feat/store-changes-filter-by-start-time
branch
from
December 16, 2024 22:01
5f4cb09 to
53af06c
Compare
ewanharris
approved these changes
Dec 17, 2024
4 tasks
4 tasks
This was referenced Jan 10, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implementing start time option in read changes endpoint
References
openfga/api#204
Review Checklist
mainIf you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)