Skip to content

feat: support start time parameter on read changes#158

Merged
rhamzeh merged 6 commits into
openfga:mainfrom
ryanpq:feat-support-start_time-parameter-on-read_changes
Jan 14, 2025
Merged

feat: support start time parameter on read changes#158
rhamzeh merged 6 commits into
openfga:mainfrom
ryanpq:feat-support-start_time-parameter-on-read_changes

Conversation

@ryanpq

@ryanpq ryanpq commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

Description

  • Updates max retry policy
  • Adds support for start_time parameter in read changes

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ryanpq
ryanpq requested review from a team as code owners January 14, 2025 17:13
@codecov-commenter

codecov-commenter commented Jan 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 3.46821% with 167 lines in your changes missing coverage. Please review.

Project coverage is 25.68%. Comparing base (2adebcc) to head (7474b61).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
model_forbidden_response.go 0.00% 79 Missing ⚠️
model_auth_error_code.go 0.00% 45 Missing ⚠️
model_assertion.go 0.00% 42 Missing ⚠️
configuration.go 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (25.68%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   25.98%   25.68%   -0.30%     
==========================================
  Files         102      104       +2     
  Lines       12405    12577     +172     
==========================================
+ Hits         3223     3231       +8     
- Misses       8911     9075     +164     
  Partials      271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread CHANGELOG.md
@rhamzeh rhamzeh changed the title Feat support start time parameter on read changes feat: support start time parameter on read changes Jan 14, 2025
- Add default retry change to changelog
- Add PR reference to new changelog entries
@rhamzeh
rhamzeh added this pull request to the merge queue Jan 14, 2025
Merged via the queue into openfga:main with commit 9b6f886 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants