feat: support start_time parameter on read_changes - #186
Merged
rhamzeh merged 6 commits intoJan 6, 2025
Merged
Conversation
Contributor
Author
|
Note: This currently includes the read changes start_time variable but does not include Batch Check updates. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 87.70% 87.65% -0.06%
==========================================
Files 23 23
Lines 1139 1142 +3
Branches 196 198 +2
==========================================
+ Hits 999 1001 +2
Misses 83 83
- Partials 57 58 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryanpq
force-pushed
the
feat-support-start_time-parameter-on-read_changes
branch
from
December 30, 2024 18:27
4e02e59 to
cda05b4
Compare
ewanharris
reviewed
Jan 6, 2025
ewanharris
left a comment
Member
There was a problem hiding this comment.
Code changes look good.
I'd discard the changes in package-lock.json to fix CI (I always find it awkward to keep this in sync correctly with sdk-generator), and also the eslint file that looks to have been added.
Member
rhamzeh
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds support for the start_time variable for read changes.
References
openfga/sdk-generator#455
Review Checklist
main