Skip to content

feat: Support for start time in read changes request - #92

Closed
ryanpq wants to merge 10 commits into
openfga:mainfrom
ryanpq:chore-update-dotNET-sdk-with-changes-from-sdk-generator
Closed

feat: Support for start time in read changes request#92
ryanpq wants to merge 10 commits into
openfga:mainfrom
ryanpq:chore-update-dotNET-sdk-with-changes-from-sdk-generator

Conversation

@ryanpq

@ryanpq ryanpq commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Description

Pulls updates from sdk-generator after latest release and adds support for start time in read changes

References

openfga/sdk-generator#455
openfga/sdk-generator#420
openfga/sdk-generator#398

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ryanpq
ryanpq requested review from a team as code owners February 6, 2025 16:39
@codecov-commenter

codecov-commenter commented Feb 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 11.90476% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.70%. Comparing base (bfb5447) to head (72e8452).
⚠️ Report is 63 commits behind head on main.

Files with missing lines Patch % Lines
src/OpenFga.Sdk/Model/ForbiddenResponse.cs 0.00% 49 Missing ⚠️
src/OpenFga.Sdk/Model/Assertion.cs 22.72% 17 Missing ⚠️
src/OpenFga.Sdk/Model/ReadRequest.cs 0.00% 6 Missing ⚠️
src/OpenFga.Sdk/Api/OpenFgaApi.cs 75.00% 0 Missing and 1 partial ⚠️
src/OpenFga.Sdk/Client/Client.cs 0.00% 0 Missing and 1 partial ⚠️

❌ Your project status has failed because the head coverage (32.70%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   33.00%   32.70%   -0.31%     
==========================================
  Files         128      129       +1     
  Lines        6387     6467      +80     
  Branches      840      851      +11     
==========================================
+ Hits         2108     2115       +7     
- Misses       4099     4171      +72     
- Partials      180      181       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

this.ContextualTuples.SequenceEqual(input.ContextualTuples)
) &&
(
this.Context == input.Context ||

Check warning

Code scanning / CodeQL

Reference equality test on System.Object

Reference equality for System.Object comparisons ([this](1) argument has type Object).
/// <param name="input">Object to be compared</param>
/// <returns>Boolean</returns>
public override bool Equals(object input) {
return this.Equals(input as ForbiddenResponse);

Check warning

Code scanning / CodeQL

Equals should not apply "as"

ForbiddenResponse.Equals(object) should not use "as" on its parameter, as it will not work properly for subclasses of ForbiddenResponse.
Comment on lines +101 to +110
(
this.Code == input.Code ||
this.Code.Equals(input.Code)
) &&
(
this.Message == input.Message ||
(this.Message != null &&
this.Message.Equals(input.Message))
)
&& (this.AdditionalProperties.Count == input.AdditionalProperties.Count && !this.AdditionalProperties.Except(input.AdditionalProperties).Any());

Check notice

Code scanning / CodeQL

Complex condition

Complex condition: too many logical operations in this expression.
Comment thread src/OpenFga.Sdk/Api/OpenFgaApi.cs Outdated
@rhamzeh
rhamzeh self-requested a review February 21, 2025 12:21

@rhamzeh rhamzeh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

rhamzeh
rhamzeh previously approved these changes Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants