Verification: Switch class-based Sass @extend rules to use Sass placeholder syntax - #990
Merged
Merged
Conversation
Contributor
Author
|
@frrrances and @marcotuts, since this is a large number of transitions, would you two mind taking a look through the code as well as proofing Verification pages (and making sure Forums/other LMS stuff isn't affected)? @dianakhuang, just a heads up that this is a large number of changes, but no visual aspect of the Verification Process views should change with it. |
Contributor
|
looks good to me! 👍 |
…to use Sass placeholder syntax
Contributor
Author
|
@jzoldak, here's one of the PRs that's switching up our Sass (not selectors, but extends that are used/processed in rulesets) |
talbs
added a commit
that referenced
this pull request
Sep 16, 2013
Verification: Switch class-based Sass @extend rules to use Sass placeholder syntax
Contributor
Author
|
Bringing this to "Mergetown". |
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Jul 19, 2016
* Fix register student of biz with celery openedx#909 * Skip bok-choy test until implements with task history.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Aug 9, 2016
* Fix register student of biz with celery openedx#909 * Skip bok-choy test until implements with task history. Conflicts: biz/djangoapps/ga_contract_operation/tests/factories.py biz/djangoapps/ga_contract_operation/views.py
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Aug 9, 2016
…ry-cypress Cherry-pick Cypress openedx#977 openedx#981 openedx#988 openedx#990 openedx#998 openedx#1011
jcdyer
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 9, 2018
YONK-845: Bumped mobileapps & api-integration version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work aims to move any class-based (e.g. ".ui-fake-link") Sass @extend into the new placeholder (e.g. %ui-fake-link) syntax (introduced in Sass 3.2). This work does not touch the following:
Since we want to repurpose some of this work for future LMS stuff, it made sense to get this stuff into shape now. This will cut down selector specificity and rendered CSS duplication/redundancy significantly.
For more info around the differences and some background, see - http://blog.teamtreehouse.com/extending-placeholder-selectors-with-sass