Software Secure message signing pt. 2 - #994
Merged
Merged
Conversation
Contributor
Author
|
Oh, I branched off of the latest release for this, so I've got stuff from the weekend hotfixes. Probably should merge those separately in the morning. |
Contributor
|
I can update the hotfix branch to fix those errors. Also, I'm going to pull in PR #966 into this branch so that fix can end up on |
Contributor
|
👍 |
ormsbee
pushed a commit
that referenced
this pull request
Sep 16, 2013
Software Secure message signing pt. 2
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
Add MySQL-python to the requirements.
jenkins-ks
pushed a commit
to nttks/edx-platform
that referenced
this pull request
Aug 9, 2016
…ry-cypress Cherry-pick Cypress openedx#977 openedx#981 openedx#988 openedx#990 openedx#998 openedx#1011
jcdyer
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 9, 2018
…lder-version-bump MCKIN-6513 Bump Problem Builder version
DanielVZ96
pushed a commit
to open-craft/openedx-platform
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes another unicode bug (turns out json.dumps can return str or unicode depending on args). Also extends Software Secure message signing code to handle more complex data structures. That being said, we are still getting incompatibilities on the receive side, so I'm falling back to authenticating messages using the shared access key rather than signing. We still sign messages to SS, which has always worked. @dianakhuang