Skip to content

Pull XModule attributes out into a mixin that can be applied to xblocks - #909

Merged
cpennington merged 1 commit into
openedx:masterfrom
cpennington:xmodule-mixin
Sep 27, 2013
Merged

Pull XModule attributes out into a mixin that can be applied to xblocks#909
cpennington merged 1 commit into
openedx:masterfrom
cpennington:xmodule-mixin

Conversation

@cpennington

Copy link
Copy Markdown
Contributor

@nedbat, @sarina: Review?

Things to look at:

  1. Verify that any attribute removed from XModule or XModuleDescriptor is available in XModuleMixin
  2. Make sure that XModuleMixin is added to the LMS and Studio configuration
  3. Verify that attributes in XModuleMixin depend only on the XBlock interface or other XModuleMixin attributes

Comment thread common/lib/xmodule/xmodule/x_module.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Descriptor

@nedbat

nedbat commented Sep 26, 2013

Copy link
Copy Markdown
Contributor

It's "just" moving things around: 👍

@sarina

sarina commented Sep 26, 2013

Copy link
Copy Markdown
Contributor

ya agree w/ nedbat 👍

cpennington added a commit that referenced this pull request Sep 27, 2013
Pull XModule attributes out into a mixin that can be applied to xblocks
@cpennington
cpennington merged commit eebc524 into openedx:master Sep 27, 2013
@cpennington
cpennington deleted the xmodule-mixin branch September 27, 2013 17:49
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Jul 19, 2016
* Fix register student of biz with celery openedx#909

* Skip bok-choy test until implements with task history.
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Aug 9, 2016
* Fix register student of biz with celery openedx#909

* Skip bok-choy test until implements with task history.

Conflicts:
	biz/djangoapps/ga_contract_operation/tests/factories.py
	biz/djangoapps/ga_contract_operation/views.py
andrey-canon pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 7, 2018
kluo pushed a commit to kluo/edx-platform that referenced this pull request Oct 19, 2019
* Commits:
  Remove CME test restriction
  Remove CME integrations
  Remove CME code
DanielVZ96 pushed a commit to open-craft/openedx-platform that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants