Make descriptorsystem inherit from Runtime - #567
Merged
Conversation
Author
Contributor
|
I would just include this in the PR that actually uses the render method. |
Author
|
Fair enough - there it is. I imagine wrapping content around a constant function while we don't yet make the switch to the wrap_xmodule alternative is the way to go? |
Contributor
There was a problem hiding this comment.
I think, to keep things separated the way we want them to end up, I would set component.get_html = wrap_xmodule(component.get_html, component, 'xmodule_edit.html') before the call to render_to_response and then 'editor': component.runtime.render(component, None, 'studio_view').content in the call to render_to_response. That way, when we later replace wrap_xmodule with an implementation of wrap_child in the runtime, we'll only have to change the line that replaces get_html, rather than having to rewrite both places.
Author
|
@dianakhuang ? Cale's out |
Contributor
|
I would suggest that @nedbat review this instead of me. |
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
added 2 commits
August 12, 2013 15:00
Conflicts: cms/djangoapps/contentstore/views/preview.py
jkarni
pushed a commit
that referenced
this pull request
Aug 12, 2013
Make descriptorsystem inherit from Runtime
chrisrossi
pushed a commit
to jazkarta/edx-platform
that referenced
this pull request
Mar 31, 2014
…dulestores Eagerly load modulestores on server startup
e-kolpakov
referenced
this pull request
in open-craft/openedx-platform
Dec 4, 2015
Hash update: Group Project V2
caesar2164
pushed a commit
to caesar2164/edx-platform
that referenced
this pull request
Jan 24, 2017
…attutor_sha Update StatTutor sha for 1/13 code
jfavellar90
pushed a commit
to eduNEXT/edx-platform
that referenced
this pull request
Apr 11, 2018
* FIX: key error * Proversity/development (openedx#546) * removing setting configure and rather setting setting module to lms * try sys convert * FIX: key error * add changes to development branch (openedx#538) * add changes to development branch * comments * remove mig file * [ci skip] switcching to proversity fork of social auths * [ci skip] fixing encoding * [Development] Update clear course cache (openedx#542) * FIX: key error * update clear-course-cache to accept multiple courses * [ci skip] reverting conftest * Proversity/development (openedx#558) ENH: bulk grades api to be granular ENH: course order by ADD: harambee custom backend SSO * dynamically update release dates
dgamanenko
referenced
this pull request
in raccoongang/edx-platform
Jun 14, 2018
* FIX: key error * Proversity/development (#546) * removing setting configure and rather setting setting module to lms * try sys convert * FIX: key error * add changes to development branch (#538) * add changes to development branch * comments * remove mig file * [ci skip] switcching to proversity fork of social auths * [ci skip] fixing encoding * [Development] Update clear course cache (#542) * FIX: key error * update clear-course-cache to accept multiple courses * [ci skip] reverting conftest * Proversity/development (#558) ENH: bulk grades api to be granular ENH: course order by ADD: harambee custom backend SSO * dynamically update release dates
mariajgrimaldi
added a commit
to eduNEXT/edx-platform
that referenced
this pull request
Nov 5, 2021
JU-6: add support for openedx-events
Sujeet1379
pushed a commit
to chandrudev/edx-platform
that referenced
this pull request
Nov 17, 2022
Co-authored-by: SaadYousaf <saadyousaf@A006-00314.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptors also need a runtime.render method.
Switch to studio_view
[STUD-515]