Add error messaging to course team page - #538
Conversation
Hitting "Add User" with no email address, or trying to add a user to the course team multiple times
There was a problem hiding this comment.
I think the course name should be in quotes. Otherwise the message is very awkward for courses with a space in the name.
|
I'm seeing this message showing up "Promote another member to Admin to remove your admin rights" for users that are not the one logged in. Repro steps:
When logged in with an account that is NOT marked "is_staff", I see a different (probably more serious) issue. It would be great to have a test for this.
|
|
Update BDD spec for changes (and Jasmine/Lettuce tests as appropriate). |
There was a problem hiding this comment.
Same thing about course name needing to be quoted.
|
@talbs I have a general style question. Should we use single quotes or double quotes for quoting things? For instance, to quote the name of the course in the error message, should it be "Your New Course" or 'Your New Course'? The error we get back if the e-mail does not exist has the e-mail address in single quotes (Could not find user by e-mail address 'foo@foo.bar'). We should be consistent, but I'm not sure what the correct way is. |
There was a problem hiding this comment.
Change to CMS.Models.Course. Only using the name field.
They contain too much incorrect permission checking
Initialize on every page that has a context_course set
There was a problem hiding this comment.
Can we confirm that the admin rights have been removed? I think all the steps below would pass even if admin rights did not get revoked from the original user.
|
👍 After additional test is done. |
|
Love it. 👍 |
Add error messaging to course team page
|
@cahrens, RE: quotation mark standards - I agree we should be consistent. I think double marks is a fine way to go. To add fuel to the fire, should these characters be transformed into HTML entity-based double quotes (” and “)? |
…edit partial credit for an inputfield May want to couple this (in the future) with some UI feedback to indicate partial credit was awarded.
* stv/bump/inline-drop-down: Bump InlineDropDown XBlock
* add changes to development branch * comments * remove mig file
* removing setting configure and rather setting setting module to lms * try sys convert * FIX: key error * add changes to development branch (openedx#538) * add changes to development branch * comments * remove mig file * [ci skip] switcching to proversity fork of social auths * [ci skip] fixing encoding * [Development] Update clear course cache (openedx#542) * FIX: key error * update clear-course-cache to accept multiple courses * [ci skip] reverting conftest
* FIX: key error * Proversity/development (openedx#546) * removing setting configure and rather setting setting module to lms * try sys convert * FIX: key error * add changes to development branch (openedx#538) * add changes to development branch * comments * remove mig file * [ci skip] switcching to proversity fork of social auths * [ci skip] fixing encoding * [Development] Update clear course cache (openedx#542) * FIX: key error * update clear-course-cache to accept multiple courses * [ci skip] reverting conftest * Proversity/development (openedx#558) ENH: bulk grades api to be granular ENH: course order by ADD: harambee custom backend SSO * dynamically update release dates
* add changes to development branch * comments * remove mig file
* removing setting configure and rather setting setting module to lms * try sys convert * FIX: key error * add changes to development branch (#538) * add changes to development branch * comments * remove mig file * [ci skip] switcching to proversity fork of social auths * [ci skip] fixing encoding * [Development] Update clear course cache (#542) * FIX: key error * update clear-course-cache to accept multiple courses * [ci skip] reverting conftest
* FIX: key error * Proversity/development (#546) * removing setting configure and rather setting setting module to lms * try sys convert * FIX: key error * add changes to development branch (#538) * add changes to development branch * comments * remove mig file * [ci skip] switcching to proversity fork of social auths * [ci skip] fixing encoding * [Development] Update clear course cache (#542) * FIX: key error * update clear-course-cache to accept multiple courses * [ci skip] reverting conftest * Proversity/development (#558) ENH: bulk grades api to be granular ENH: course order by ADD: harambee custom backend SSO * dynamically update release dates
3 participants
Hitting "Add User" with no email address, or trying to add a user to the course
team multiple times. Also added confirmation prompt when deleting a user from a course team.