Skip to content

Fix upload assets by chunks - #546

Closed
maximst wants to merge 2 commits into
ginkgo-rgfrom
ginkgo-rg-27
Closed

Fix upload assets by chunks#546
maximst wants to merge 2 commits into
ginkgo-rgfrom
ginkgo-rg-27

Conversation

@maximst

@maximst maximst commented Aug 29, 2018

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #546 into ginkgo-rg will increase coverage by <.01%.
The diff coverage is 41.66%.

Impacted file tree graph

@@              Coverage Diff              @@
##           ginkgo-rg     #546      +/-   ##
=============================================
+ Coverage       94.8%   94.81%   +<.01%     
=============================================
  Files           1862     1862              
  Lines         170570   171606    +1036     
=============================================
+ Hits          161711   162708     +997     
- Misses          8859     8898      +39
Impacted Files Coverage Δ
cms/djangoapps/contentstore/views/assets.py 86.34% <41.66%> (-9.55%) ⬇️
lms/djangoapps/shoppingcart/tests/test_views.py 100% <0%> (ø) ⬆️
cms/djangoapps/contentstore/signals/handlers.py 95.16% <0%> (+0.16%) ⬆️
lms/djangoapps/shoppingcart/views.py 97.58% <0%> (+0.27%) ⬆️
lms/djangoapps/dashboard/sysadmin.py 65.63% <0%> (+0.96%) ⬆️
cms/djangoapps/contentstore/tests/test_utils.py 97.04% <0%> (+0.96%) ⬆️
cms/djangoapps/contentstore/utils.py 97.13% <0%> (+1.15%) ⬆️
lms/djangoapps/dashboard/tests/test_sysadmin.py 98.65% <0%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e271fa8...e00c899. Read the comment docs.

Comment thread cms/djangoapps/contentstore/views/assets.py
@maximst
maximst requested review from oksana-slu and realARCHaim and removed request for realARCHaim September 3, 2018 07:07
@cmltaWt0

Copy link
Copy Markdown

Is this PS stale? Should it be closed?

@realARCHaim

Copy link
Copy Markdown

Is this PS stale? Should it be closed?
Don't see nothing significant enough that prevents it from closing.

@realARCHaim realARCHaim reopened this Feb 20, 2019
@cmltaWt0 cmltaWt0 closed this Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants