Skip to content

Create urls/views/templates for dev-only views - #546

Merged
singingwolfboy merged 2 commits into
masterfrom
db/dev-views
Aug 1, 2013
Merged

Create urls/views/templates for dev-only views#546
singingwolfboy merged 2 commits into
masterfrom
db/dev-views

Conversation

@singingwolfboy

Copy link
Copy Markdown
Contributor

Our designers find it helpful to be able to stub out simple views that aren't ready
to be seen for production yet, and check them into version control so that other
people can see them and provide feedback. This commit introduces a few new files
and directories for this purpose, as well as a sample view that will only be seen
in dev mode, and never in production.

Our designers find it helpful to be able to stub out simple views that aren't ready
to be seen for production yet, and check them into version control so that other
people can see them and provide feedback. This commit introduces a few new files
and directories for this purpose, as well as a sample view that will only be seen
in dev mode, and never in production.
@singingwolfboy

Copy link
Copy Markdown
Contributor Author

Would it be better to define the dev-only urlpatterns at the top of views/dev.py, have urls.py import it from view/dev.py, and kill off urls_dev.py? Or is it better to keep the views and the urlpatterns in separate files?

@talbs

talbs commented Aug 1, 2013

Copy link
Copy Markdown
Contributor

Thanks, @singingwolfboy.

To help provide some context for this effort/request, there are two scenarios that this type of infrastructure would be helpful with:

  1. Design/UI documentation: to help communicate design and UI patterns currently used, we could use views that help define elements, style options, and provide front-end examples of them. The design team has talked about views like this aiding with making new features' UI 1) consistent with any other similar elements in the app and 2) re-usable in the future if there are new patterns being made.
  2. Design prototyping: for larger features or ones that design has more of a heads-up on, it'd be helpful to have a static space to jump into prototyping with that wouldn't 1) disturb the existing production-ready views of app and 2) require help from the development team to set up views in each individual case. These spaces could then be kept if the designer thinks its worth it for future documentation/refinement or removed once the branch/work is moved into delivery and production-level code/views are written.

@frrrances, we've talked recently about this. Feel free to chime in with any thoughts.

@frrrances

Copy link
Copy Markdown
Contributor

@talbs pretty much summed up my feelings. Not sure how this will affect the dev/production split, but it would be helpful to have a static space where we can leverage the base html, sass, and js files but still have an area to really muck about.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cahrens

cahrens commented Aug 1, 2013

Copy link
Copy Markdown

👍 once pep8/pylint cleanup.

singingwolfboy added a commit that referenced this pull request Aug 1, 2013
Create urls/views/templates for dev-only views
@singingwolfboy
singingwolfboy merged commit 1b83cfc into master Aug 1, 2013
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
hide reply button after closing thread
e-kolpakov referenced this pull request in open-craft/openedx-platform Oct 28, 2015
Revert "Automatic account provisioning for opted-in SAML providers"
jfavellar90 pushed a commit to eduNEXT/edx-platform that referenced this pull request Apr 11, 2018
* removing setting configure and rather setting setting module to lms

* try sys convert

* FIX: key error

* add changes to development branch (openedx#538)

* add changes to development branch

* comments

* remove mig file

* [ci skip] switcching to proversity fork of social auths

* [ci skip] fixing encoding

* [Development] Update clear course cache (openedx#542)

* FIX: key error

* update clear-course-cache to accept multiple courses

* [ci skip] reverting conftest
jfavellar90 pushed a commit to eduNEXT/edx-platform that referenced this pull request Apr 11, 2018
* FIX: key error

* Proversity/development (openedx#546)

* removing setting configure and rather setting setting module to lms

* try sys convert

* FIX: key error

* add changes to development branch (openedx#538)

* add changes to development branch

* comments

* remove mig file

* [ci skip] switcching to proversity fork of social auths

* [ci skip] fixing encoding

* [Development] Update clear course cache (openedx#542)

* FIX: key error

* update clear-course-cache to accept multiple courses

* [ci skip] reverting conftest

* Proversity/development (openedx#558)

ENH: bulk grades api to be granular
ENH: course order by
ADD: harambee custom backend SSO

* dynamically update release dates
dgamanenko referenced this pull request in raccoongang/edx-platform Jun 14, 2018
* removing setting configure and rather setting setting module to lms

* try sys convert

* FIX: key error

* add changes to development branch (#538)

* add changes to development branch

* comments

* remove mig file

* [ci skip] switcching to proversity fork of social auths

* [ci skip] fixing encoding

* [Development] Update clear course cache (#542)

* FIX: key error

* update clear-course-cache to accept multiple courses

* [ci skip] reverting conftest
dgamanenko referenced this pull request in raccoongang/edx-platform Jun 14, 2018
* FIX: key error

* Proversity/development (#546)

* removing setting configure and rather setting setting module to lms

* try sys convert

* FIX: key error

* add changes to development branch (#538)

* add changes to development branch

* comments

* remove mig file

* [ci skip] switcching to proversity fork of social auths

* [ci skip] fixing encoding

* [Development] Update clear course cache (#542)

* FIX: key error

* update clear-course-cache to accept multiple courses

* [ci skip] reverting conftest

* Proversity/development (#558)

ENH: bulk grades api to be granular
ENH: course order by
ADD: harambee custom backend SSO

* dynamically update release dates
yoann-mroz pushed a commit to weuplearning/edx-platform that referenced this pull request Nov 30, 2020
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants