This repository was archived by the owner on Oct 13, 2025. It is now read-only.
fix: pagination behaviour of user active threads API [BD-38] - #389
Merged
Conversation
openedx-webhooks
added
the
blended
|
Thanks for the pull request, @xitij2000! When this pull request is ready, tag your edX technical lead. |
kaustavb12
reviewed
Sep 13, 2022
kaustavb12
approved these changes
Sep 13, 2022
kaustavb12
left a comment
kaustavb12
left a comment
There was a problem hiding this comment.
👍
- I tested this: I tested the expected behaviour of the API
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
Contributor
|
👍
|
asadazam93
approved these changes
Nov 4, 2022
Contributor
|
@xitij2000 can you please rebase this? |
When using the default `user_activity` filter for the active threads API, the pagination and sorting happens in Ruby instead of MongoDB. In addition, when using the unread filter, the pagination mechanism is different. This code introduces a fix for when they are both used together.
xitij2000
force-pushed
the
kshitij/fix-unread-pagination
branch
from
November 7, 2022 11:10
12cbcac to
5f227e1
Compare
|
@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the default
user_activityfilter for the active threads API, thepagination and sorting happens in Ruby instead of MongoDB. In addition, when
using the unread filter, the pagination mechanism is different. This code
introduces a fix for when they are both used together.