This repository was archived by the owner on Oct 13, 2025. It is now read-only.
[BD-38][INF-544][BB-6682] feat: implement reverse_order parameter - #398
Merged
asadazam93 merged 2 commits intoNov 15, 2022
Merged
Conversation
|
Thanks for the pull request, @0x29a! When this pull request is ready, tag your edX technical lead. |
0x29a
force-pushed
the
0x29a/bb6682/add_reverse_order_param
branch
3 times, most recently
from
October 31, 2022 06:01
416c4c9 to
682c50a
Compare
0x29a
commented
Oct 31, 2022
Comment on lines
-130
to
-132
| if ancestry.empty? # invalid parent; ignore item | ||
| next | ||
| end |
Contributor
Author
There was a problem hiding this comment.
This code does nothing.
0x29a
force-pushed
the
0x29a/bb6682/add_reverse_order_param
branch
from
October 31, 2022 07:37
682c50a to
8ded698
Compare
xitij2000
approved these changes
Oct 31, 2022
xitij2000
left a comment
Contributor
There was a problem hiding this comment.
👍 Just one small comment. Looks good otherwise, and it seems to be working well.
- I tested this: tested on devstack
- I read through the code
xitij2000
force-pushed
the
0x29a/bb6682/add_reverse_order_param
branch
from
November 8, 2022 07:40
5d39158 to
909b40a
Compare
Contributor
|
@0x29a can you please rebase this? |
0x29a
force-pushed
the
0x29a/bb6682/add_reverse_order_param
branch
from
November 8, 2022 11:23
909b40a to
e4c03a0
Compare
Contributor
Author
|
@asadazam93, done. |
asadazam93
approved these changes
Nov 15, 2022
|
@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
ghassanmas
pushed a commit
to ghassanmas/cs_comments_service
that referenced
this pull request
Dec 9, 2022
…82/add_reverse_order_param [BD-38][INF-544][BB-6682] feat: implement reverse_order parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
reverse_orderquery parameter to the threads endpoint.merge_response_contentto support reversed content order.Testing instructions
reverse_order==falsetoreverse_order==true. You should see threads and comments in the reversed order.resp_limit==1to verify that the reverse ordering works with pagination.