update: clean up old code before refactor by zdtsw · Pull Request #1494 · opendatahub-io/opendatahub-operator

zdtsw · 2025-01-10T14:51:45Z

remove reference we explicilty check on odhdashboardconfig and kserve, these are not used after refactor which does not call createResource on previous DSC "owned" ones
remove customized config on controller QPS
remove passing dscApplicationsNamespace in main to createdefaultDSCI, since we have default value set in the api, we do not need that value which is another default from --dsc-applications-namespace from flag
remove flag --operator-name which is not used anywhere

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

You have read the contributors guide.
Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work

biswassri · 2025-01-10T14:56:39Z

@zdtsw Maybe we can also include removing this RemoveLabel function, it's an unused function.

zdtsw · 2025-01-10T16:36:42Z

@zdtsw Maybe we can also include removing this RemoveLabel function, it's an unused function.

good point
i did not know we still have such functions.
i will include them

zdtsw · 2025-01-11T17:30:59Z

/test opendatahub-operator-e2e

codecov · 2025-01-13T16:38:19Z

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 20.10%. Comparing base (eb42450) to head (c50672c).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/upgrade/upgrade.go	0.00%	19 Missing ⚠️
.../dscinitialization/dscinitialization_controller.go	0.00%	2 Missing ⚠️
pkg/deploy/deploy.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
+ Coverage   19.84%   20.10%   +0.26%     
==========================================
  Files         159      159              
  Lines       10794    10707      -87     
==========================================
+ Hits         2142     2153      +11     
+ Misses       8424     8326      -98     
  Partials      228      228

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…flux/component-updates/odh-kuberay-operator-controller-v2-17 chore(deps): update odh-kuberay-operator-controller-v2-17 to e961fd0

- remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com>

- remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com>

- application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com>

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

openshift-ci · 2025-01-27T11:19:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ykaliuta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <git@grdryn.xyz> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <git@grdryn.xyz> commit df5495e Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit ca2f619 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a996732 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 94095f9 Author: Dipanshu Gupta <97534722+dpanshug@users.noreply.github.com> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <wenzhou@redhat.com> commit 9aed5e0 Author: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a8eb6ff Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 7b4dfc2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a00aa61 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit eb42450 Author: Manjunath Kumatagi <mkumatag@in.ibm.com> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 63d4eab Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 912dcaa Author: Ugo Giordano <ugiordan@redhat.com> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 9845f7e Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 871c799 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 28d0fa1 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 5bcbaba Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 21eba1b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI

ykaliuta · 2025-01-29T13:18:36Z

+func CreateDefaultDSCI(ctx context.Context, cli client.Client, _ cluster.Platform, monNamespace string) error {
 	log := logf.FromContext(ctx)
 	defaultDsciSpec := &dsciv1.DSCInitializationSpec{
-		ApplicationsNamespace: appNamespace,


Looks like it causes some problems

Api sets default value to opendatahub, but without "omitempty" the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <wenzhou@redhat.com> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <git@grdryn.xyz> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <git@grdryn.xyz> commit df5495e Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit ca2f619 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a996732 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 94095f9 Author: Dipanshu Gupta <97534722+dpanshug@users.noreply.github.com> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <wenzhou@redhat.com> commit 9aed5e0 Author: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a8eb6ff Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 7b4dfc2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a00aa61 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit eb42450 Author: Manjunath Kumatagi <mkumatag@in.ibm.com> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 63d4eab Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 912dcaa Author: Ugo Giordano <ugiordan@redhat.com> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 9845f7e Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 871c799 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 28d0fa1 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 5bcbaba Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 21eba1b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI

Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <wenzhou@redhat.com> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <git@grdryn.xyz> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <git@grdryn.xyz> commit df5495e Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit ca2f619 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a996732 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 94095f9 Author: Dipanshu Gupta <97534722+dpanshug@users.noreply.github.com> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <wenzhou@redhat.com> commit 9aed5e0 Author: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a8eb6ff Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 7b4dfc2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a00aa61 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit eb42450 Author: Manjunath Kumatagi <mkumatag@in.ibm.com> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 63d4eab Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 912dcaa Author: Ugo Giordano <ugiordan@redhat.com> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 9845f7e Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 871c799 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 28d0fa1 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 5bcbaba Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 21eba1b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI

#1585) Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>

commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <wenzhou@redhat.com> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <git@grdryn.xyz> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <git@grdryn.xyz> commit df5495e Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit ca2f619 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a996732 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 94095f9 Author: Dipanshu Gupta <97534722+dpanshug@users.noreply.github.com> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <wenzhou@redhat.com> commit 9aed5e0 Author: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a8eb6ff Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 7b4dfc2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a00aa61 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit eb42450 Author: Manjunath Kumatagi <mkumatag@in.ibm.com> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 63d4eab Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 912dcaa Author: Ugo Giordano <ugiordan@redhat.com> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 9845f7e Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 871c799 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 28d0fa1 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 5bcbaba Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 21eba1b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI

* update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b0a0f87)

opendatahub-io#1585) Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (opendatahub-io#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit 768539c)

commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <wenzhou@redhat.com> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (opendatahub-io#1581) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (opendatahub-io#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <git@grdryn.xyz> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <git@grdryn.xyz> commit df5495e Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (opendatahub-io#1575) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit ca2f619 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (opendatahub-io#1576) - add update on all cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a996732 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (opendatahub-io#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 94095f9 Author: Dipanshu Gupta <97534722+dpanshug@users.noreply.github.com> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (opendatahub-io#1573) commit 3056ab4 Author: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (opendatahub-io#1574) commit d538956 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (opendatahub-io#1541) Co-authored-by: Wen Zhou <wenzhou@redhat.com> commit 9aed5e0 Author: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (opendatahub-io#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (opendatahub-io#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a8eb6ff Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (opendatahub-io#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (opendatahub-io#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 7b4dfc2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (opendatahub-io#1567) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a00aa61 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (opendatahub-io#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit eb42450 Author: Manjunath Kumatagi <mkumatag@in.ibm.com> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (opendatahub-io#1549) commit bc63cfd Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (opendatahub-io#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 63d4eab Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (opendatahub-io#1558) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 912dcaa Author: Ugo Giordano <ugiordan@redhat.com> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (opendatahub-io#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (opendatahub-io#1553) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 9845f7e Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (opendatahub-io#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 871c799 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (opendatahub-io#1555) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 28d0fa1 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (opendatahub-io#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 5bcbaba Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (opendatahub-io#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (opendatahub-io#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (opendatahub-io#1544) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 21eba1b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (opendatahub-io#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (opendatahub-io#1540) This reduce the direct dependency from Monitoring to DSCI

* Map component versions to RHOAI status for better visibility commit 8caaedfbbc7da4890f41496275a71e4364730646 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:09:34 2025 +0100 added generated files commit aedbf41 Merge: 9135927 6e134b1 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 16:00:38 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 9135927 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 15:28:08 2025 +0100 removed releases from dashboard since not needed and renamed ComponentReleaseStatus into ComponentRelease commit 237806d Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:56:50 2025 +0100 removed releases from dashboard since not needed commit 6e134b1 Author: Wen Zhou <wenzhou@redhat.com> Date: Wed Jan 29 12:41:18 2025 +0100 fix: missing permission to update prometheusrules (#1581) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a044cda Merge: 2571965 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 12:13:12 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit 2571965 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:42:27 2025 +0100 Map component versions to RHOAI status for better visibility commit 0f1cf7dd9ca20e41c97a1590e18dc888b68e9fd5 Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:40:58 2025 +0100 fix lint error commit 473e86f55fd87e496c5d4251d075dc1082ce6e4c Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 3d47679 Merge: d706b92 bd00c9b Author: Ugo Giordano <ugiordan@redhat.com> Date: Wed Jan 29 11:32:16 2025 +0100 Merge branch 'main' into RHOAIENG-11648/component-mapping-refactor commit d706b92 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 18:00:29 2025 +0100 Remove fetch releases action from dashboard & e2e tests commit 4e0deb2 Author: Ugo Giordano <ugiordan@redhat.com> Date: Tue Jan 28 16:10:28 2025 +0100 unit test e2e tests commit bd00c9b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 23:53:01 2025 +0100 Improve Kserve's FeatureTraker handing (#1562) * Improve Kserve's FeatureTraker handing - Make it possible to set FT's OwnerReference as Controller reference so the kubernetes garbage collector can block owner deletion till the FT has been deleted - Make it possible to set FT's generated resources OwnerReference as Controller reference so the kubernetes garbage collector can block FT deletion till the resources have been deleted - Add an Kserver reconciler action to remove legacy ownership on DSCI/DSC is any and related e2e tests * Update RBACs * Update RBACs * Fix findings * Update pkg/cluster/meta.go Co-authored-by: Gerard Ryan <git@grdryn.xyz> * Fix renaming * Remove unrelated methods --------- Co-authored-by: Gerard Ryan <git@grdryn.xyz> commit df5495e Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:21:23 2025 +0100 docs: remove duplicated files and update integration docs (#1575) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit ca2f619 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 21:02:36 2025 +0100 fix: missing update permission on dashboard object (#1576) - add update on all cases Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a996732 Author: Wen Zhou <wenzhou@redhat.com> Date: Tue Jan 28 20:50:56 2025 +0100 fix: fix wrong map for DSP images (#1577) - the old images are from 2.15 which have been updated during 2.16 Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 94095f9 Author: Dipanshu Gupta <97534722+dpanshug@users.noreply.github.com> Date: Tue Jan 28 21:57:25 2025 +0530 Setup admin permissions for hardware profiles (#1573) commit 3056ab4 Author: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Date: Tue Jan 28 17:58:06 2025 +0530 (fix): point to correct path for component integration doc (#1574) commit d538956 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Tue Jan 28 10:01:48 2025 +0100 chore: use constants from the status package where possible (#1541) Co-authored-by: Wen Zhou <wenzhou@redhat.com> commit 9aed5e0 Author: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com> Date: Mon Jan 27 13:20:04 2025 -0500 Clarify and update permissions (#1538) * Add readme to explain values of permissions * NIM Accounts are namespaced resources * Update permissions to fulfill doc design * Based on feedback, less hard-fast ruling wording in the README commit 5e60591 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 17:33:51 2025 +0100 test: disable monitoring config in DSCI for ODH e2e test (#1570) - we do not enable monitoring in ODH logic - we should keep it enable for rhoai branch Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a8eb6ff Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:51:31 2025 +0100 fix lint add updated api doc commit 4b76ca4 Author: Ugo Giordano <ugiordan@redhat.com> Date: Mon Jan 27 16:42:00 2025 +0100 Map component versions to RHOAI status for better visibility commit 48341ff Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Mon Jan 27 15:38:21 2025 +0100 It takes more than 10 minutes for kserve-controller to be created during 2.17 installation (#1564) * It takes more than 10 minutes for kserve-controller to be created during 2.17 installation * cleanup commit b0a0f87 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 13:53:40 2025 +0100 update: clean up old code before refactor (#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 7b4dfc2 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 12:01:07 2025 +0100 fix: for upgrade case we will need update permission on buildconfig to revmoew ownerref from dsc (#1567) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit a00aa61 Author: Wen Zhou <wenzhou@redhat.com> Date: Mon Jan 27 09:00:32 2025 +0100 fix: add matchlabel on NWP for customized appliation (#1566) - update README and troubleshooting Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit eb42450 Author: Manjunath Kumatagi <mkumatag@in.ibm.com> Date: Fri Jan 24 19:11:14 2025 +0530 Build platform independent binary based on the target platform (#1549) commit bc63cfd Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 21:04:44 2025 +0100 update: change previous workaround for subscription and add smcp in the list (#1557) - remove subs from client cache - add smcp into exclude cache Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 63d4eab Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 18:44:37 2025 +0100 fix: missing monitoring NS for NWP if user opt customized app NS (#1558) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 912dcaa Author: Ugo Giordano <ugiordan@redhat.com> Date: Thu Jan 23 16:56:32 2025 +0100 Align get_all_manifests.sh with Kubeflow main branch (#1550) commit ce7b381 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Thu Jan 23 14:08:54 2025 +0100 Update version to 2.23.1 (#1553) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 9845f7e Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 14:07:25 2025 +0100 update: various fix backport from RHOAI (#1536) - fix missing RHOAI monitoring namespace for self-managed - fix wrong namespace name in manifests - update hardcode label name - fix misleading log message Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 871c799 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 13:21:29 2025 +0100 fix: as a workaround for getting knative opreator check, set cache (#1555) Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 28d0fa1 Author: Wen Zhou <wenzhou@redhat.com> Date: Thu Jan 23 11:49:37 2025 +0100 fix: add missing namespace for console in managed cluster (#1552) - blackbox require this - move into const in cluster pkg Signed-off-by: Wen Zhou <wenzhou@redhat.com> commit 5bcbaba Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 19:31:20 2025 +0100 Avoid modelmesh and Kserve loop on updating shared CRDs (#1547) The KServe and ModelMesh are shipping the same CRDs as part of their manifests but with different versions, this cause the respective component reconcilers to keep trying to install their respective version, ending in a infinite loop. This commit does not solve the underlying problem of having two components shipping the same CRDs with different versions, but avoids the infinite reconcile loop. The CRDs that is actually installed on the cluster is undefined, the latest one that is applied wins commit 8c7fef2 Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 15:45:51 2025 +0100 chore: remove unused code (#1543) * chore: remove unused TrimToRFC1123Name function * chore: remove unused pkg/cluster/roles functions * chore: remove unused pkg/cluster/resources functions commit e83f2fc Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Jan 22 13:49:00 2025 +0100 Update version to 2.23.0 (#1544) Co-authored-by: zdtsw <915053+zdtsw@users.noreply.github.com> commit 21eba1b Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 12:38:49 2025 +0100 chore: cleanup Monitoring's initialize action (#1542) The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests commit 5321b8c Author: Luca Burgazzoli <lburgazzoli@users.noreply.github.com> Date: Wed Jan 22 11:05:23 2025 +0100 fix: use Monitoring.Spec.Namespace instead of the DSCI one (#1540) This reduce the direct dependency from Monitoring to DSCI * skipping the component versions if "version" field is empty * fix linter error * Commenting out e2e tests for KServe and MM Serving until metadata is in the correct manifest folder * Merge branch 'opendatahub-io:main' into RHOAIENG-11648/component-mapping-refactor

* chore: cleanup kustomize config (#1497) - suspend too many WARNING lines from "make bundle" - remove sample config for components and monitoring Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 4fe5bed) * chore: add more rules in golint (#1487) - add rules for our API components and service which force alias to be named with suffix ctrl Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 32d75a8) * update: clean up old code before refactor (#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b0a0f87) * docs: update workflow and how we use two branchs for ODH and downstream (#1582) * docs: update workflow and how we use two branchs for ODH and downstream - add new doc for how workflow, label on PR, sync process - update branch away from incubatin in github action and reference Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update docs/sync_code.md Co-authored-by: Gerard Ryan <git@grdryn.xyz> * revert: branch related test config Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: typo Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Gerard Ryan <git@grdryn.xyz> (cherry picked from commit da75d42) * update: platform team (#1583) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 46d8ba2) * Remove Sara4994 from OWNER_ALIASES (#1598) (cherry picked from commit bf8a6e2) * github: add branch into GHA for tests (#1593) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit f4c932b) * apis: DSCInitialization: annotate ApplicationsNamespace with omitempty (#1585) Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit 768539c) * regen bundle (#1602) (cherry picked from commit 2384ada) * test: prolong e2e in rhoai for 50mins Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix:default monitoring namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Co-authored-by: Yauheni Kaliuta <ykaliuta@redhat.com> Co-authored-by: Luca Burgazzoli <lburgazzoli@users.noreply.github.com>

zdtsw requested review from VaishnaviHire and lburgazzoli January 10, 2025 14:51

openshift-ci Bot requested a review from asanzgom January 10, 2025 14:51

zdtsw force-pushed the chore_150 branch from 2dcec50 to 0462b9e Compare January 10, 2025 16:38

zdtsw force-pushed the chore_150 branch from ca2a2e9 to d1f0120 Compare January 13, 2025 12:11

zdtsw added 3 commits January 27, 2025 08:44

update: clean up old code before refactor

6e32a64

- remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com>

update:

290cc06

- remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com>

fix: Auth CR is cluster-scoped no need to set namespace for request

20dc5e2

- application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com>

zdtsw force-pushed the chore_150 branch from 49666cc to 106c550 Compare January 27, 2025 07:56

fix: wrong code for upgrade path + rebase error

c50672c

Signed-off-by: Wen Zhou <wenzhou@redhat.com>

zdtsw force-pushed the chore_150 branch from 106c550 to c50672c Compare January 27, 2025 08:10

ykaliuta approved these changes Jan 27, 2025

View reviewed changes

openshift-ci Bot assigned ykaliuta Jan 27, 2025

openshift-ci Bot added the lgtm label Jan 27, 2025

openshift-ci Bot added the approved label Jan 27, 2025

openshift-merge-bot Bot merged commit b0a0f87 into opendatahub-io:main Jan 27, 2025

ykaliuta reviewed Jan 29, 2025

View reviewed changes

ykaliuta mentioned this pull request Jan 29, 2025

apis: DSCInitialization: annotate ApplicationsNamespace with omitempty #1585

Merged

5 tasks

Navigation Menu

Repository navigation

update: clean up old code before refactor - #1494

update: clean up old code before refactor#1494
openshift-merge-bot[bot] merged 4 commits into
opendatahub-io:mainfrom
zdtsw-forking:chore_150

zdtsw commented Jan 10, 2025 •

edited

Loading

Uh oh!

biswassri commented Jan 10, 2025

Uh oh!

zdtsw commented Jan 10, 2025

Uh oh!

zdtsw commented Jan 11, 2025

Uh oh!

codecov Bot commented Jan 13, 2025 •

edited

Loading

Uh oh!

openshift-ci Bot commented Jan 27, 2025

Uh oh!

ykaliuta Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zdtsw commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

Uh oh!

biswassri commented Jan 10, 2025

Uh oh!

zdtsw commented Jan 10, 2025

Uh oh!

zdtsw commented Jan 11, 2025

Uh oh!

codecov Bot commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

openshift-ci Bot commented Jan 27, 2025

Uh oh!

ykaliuta Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zdtsw commented Jan 10, 2025 •

edited

Loading

codecov Bot commented Jan 13, 2025 •

edited

Loading