[ykaliuta]

Jira: https://issues.redhat.com/browse/RHOAIENG-18931

Api sets default value to opendatahub, but without "omitempty" in
case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like

Namespace "" is invalid: metadata.name: Required value: name or generateName is required

The problem was triggered by removing default value for command line switch in the cleanup.

Fixes: b0a0f87 ("update: clean up old code before refactor (#1494)")

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[github-actions]

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/13032878021

[ykaliuta]

/cc @lburgazzoli

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [zdtsw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.98%. Comparing base (6e134b1) to head (ddf85f0).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage   19.98%   19.98%           
=======================================
  Files         159      159           
  Lines       10780    10780           
=======================================
  Hits         2154     2154           
  Misses       8396     8396           
  Partials      230      230           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.