[mkumatag]

Description

This will ensure the dockefile can be built using the docker build, this Dockerfile directly can be used in the Konflux environment to build the image multi-arch

How Has This Been Tested?

Screenshot or short clip

Merge criteria

• You have read the contributors guide.
• Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
• Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[openshift-ci]

Hi @mkumatag. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mkumatag]

@csams wondering who can help us to merge this PR

[ykaliuta]

Will it break cross build on ARMs?

[mkumatag]

Will it break cross build on ARMs?

not at all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ykaliuta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ykaliuta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ykaliuta]

Will it break cross build on ARMs?

not at all

Yes, it does

[mkumatag]

Will it break cross build on ARMs?

not at all

Yes, it does

breaking the build on ARM? if yes - can post the error here?

[ykaliuta]

Will it break cross build on ARMs?

not at all

Yes, it does

breaking the build on ARM? if yes - can post the error here?

As expected, it produces native, ARM, binary, so the image is unusable in x86 clusters. All mac users suffer.

[mkumatag]

As expected, it produces native, ARM, binary, so the image is unusable in x86 clusters. All mac users suffer.

if someone builds this image on Apple Silicon(ARM) laptop then not just the go binary, the base image(registry.access.redhat.com/ubi8/ubi-minimal:latest) will be get shipped also will be of linux/arm64 type.

If someone wants to build it on Apple Silicon, then use following instruction to build which will ensure both binary and base container will be of targeted architecture(in this case it is linux/amd64)

$ podman build -f Dockerfiles/Dockerfile --platform linux/amd64 -t quay.io/opendatahub/opendatahub-operator:latest .

$ podman run -ti --entrypoint bash quay.io/opendatahub/opendatahub-operator:latest
WARNING: image platform (linux/amd64) does not match the expected platform (linux/arm64)
bash-4.4$ uname -a
Linux 1c5cfdaa1571 6.11.3-200.fc40.aarch64 #1 SMP PREEMPT_DYNAMIC Thu Oct 10 22:53:48 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
bash-4.4$ file /manager
/manager: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 3.2.0, BuildID[sha1]=ae10db72bdb8ea80e9028f5d1e49ae02f6a72400, with debug_info, not stripped
bash-4.4$

[ykaliuta]

if someone builds this image on Apple Silicon(ARM) laptop then not just the go binary, the base image(registry.access.redhat.com/ubi8/ubi-minimal:latest) will be get shipped also will be of linux/arm64 type.

This is not a problem since with CGO_ENABLED=0 it produces static binary.

But yes, --platform will be a solution.