Repository navigation
update: platform team - #1583
Merged
Merged
Conversation
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the opendatahub-io org. You can then trigger verification by writing
|
zdtsw
requested review from
grdryn,
gzaronikas and
tdarby
and removed request for
MarianMacik and
VaishnaviHire
January 29, 2025 11:17
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grdryn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1583 +/- ##
=======================================
Coverage 19.98% 19.98%
=======================================
Files 159 159
Lines 10780 10780
=======================================
Hits 2154 2154
Misses 8396 8396
Partials 230 230 ☔ View full report in Codecov by Sentry. |
zdtsw
added a commit
to zdtsw-forking/opendatahub-operator
that referenced
this pull request
Feb 3, 2025
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 46d8ba2)
openshift-merge-bot Bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
* chore: cleanup kustomize config (#1497) - suspend too many WARNING lines from "make bundle" - remove sample config for components and monitoring Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 4fe5bed) * chore: add more rules in golint (#1487) - add rules for our API components and service which force alias to be named with suffix ctrl Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 32d75a8) * update: clean up old code before refactor (#1494) * update: clean up old code before refactor - remove reference we explicilty check on odhdashboardconfig and kserve - remove customized config on controller QPS - remove RemoveLabel which is not called anywhere Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: - remove function for upgrade cleanup introduced before 2.8 - remove flags to main: operator namespace and application namespace ( operator namespace is passing as env variable, app namespace is done by DSCI ) Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: Auth CR is cluster-scoped no need to set namespace for request - application namespace is removed from reconciler of dsci Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: wrong code for upgrade path + rebase error Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit b0a0f87) * docs: update workflow and how we use two branchs for ODH and downstream (#1582) * docs: update workflow and how we use two branchs for ODH and downstream - add new doc for how workflow, label on PR, sync process - update branch away from incubatin in github action and reference Signed-off-by: Wen Zhou <wenzhou@redhat.com> * Update docs/sync_code.md Co-authored-by: Gerard Ryan <git@grdryn.xyz> * revert: branch related test config Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: typo Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Gerard Ryan <git@grdryn.xyz> (cherry picked from commit da75d42) * update: platform team (#1583) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 46d8ba2) * Remove Sara4994 from OWNER_ALIASES (#1598) (cherry picked from commit bf8a6e2) * github: add branch into GHA for tests (#1593) Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit f4c932b) * apis: DSCInitialization: annotate ApplicationsNamespace with omitempty (#1585) Jira: https://issues.redhat.com/browse/RHOAIENG-18931 Api sets default value to opendatahub, but without "omitempty" in case of operator automatically creates DSCI (upgrade.go:CreateDefaultDSCI), the resulting object contains applicationsNamespace: "" and it's not defaulted by the api server causing then problems like ``` Namespace "" is invalid: metadata.name: Required value: name or generateName is required ``` The problem was triggered by removing default value for command line switch in the cleanup. Fixes: b0a0f87 ("update: clean up old code before refactor (#1494)") Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com> (cherry picked from commit 768539c) * regen bundle (#1602) (cherry picked from commit 2384ada) * test: prolong e2e in rhoai for 50mins Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix:default monitoring namespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> Co-authored-by: Ajay Jaganathan <36824134+AjayJagan@users.noreply.github.com> Co-authored-by: Yauheni Kaliuta <ykaliuta@redhat.com> Co-authored-by: Luca Burgazzoli <lburgazzoli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria