Skip to content

Improved logging for OTLP receiver#1981

Merged
jmacd merged 6 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/logimpropve
Feb 7, 2026
Merged

Improved logging for OTLP receiver#1981
jmacd merged 6 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/logimpropve

Conversation

@cijothomas
Copy link
Copy Markdown
Member

Change Summary

Minor but important improvement to logging to include the endpoint where OTLP receiver is listening.
Also downgraded a registry log to debug - its polluting startup with a ton of logs, which I don't find useful, so downgrading to DEBUG from INFO. Its too much for INFO level, IMHO.

@cijothomas cijothomas requested a review from a team as a code owner February 6, 2026 20:40
@github-actions github-actions Bot added the rust Pull requests that update Rust code label Feb 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.76%. Comparing base (3d8dc2c) to head (ef5c74b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1981      +/-   ##
==========================================
- Coverage   85.77%   85.76%   -0.01%     
==========================================
  Files         513      513              
  Lines      162908   162908              
==========================================
- Hits       139731   139719      -12     
- Misses      22643    22655      +12     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 87.57% <100.00%> (-0.02%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.23% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
quiver 92.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread rust/otap-dataflow/crates/telemetry/src/registry.rs
github-merge-queue Bot pushed a commit that referenced this pull request Feb 6, 2026
Reverting #1973
Fixing the empty "" from our internal macros, that caused the
`message="user friendly message here"` from being omitted in stdout!

Taking
https://github.com/open-telemetry/otel-arrow/blob/main/rust/otap-dataflow/crates/controller/src/lib.rs#L668-L671
as example
```rust
otel_warn!(
                "core_affinity.set_failed",
                message = "Failed to set core affinity for pipeline thread. Performance may be less predictable."
            );
```

Before
```txt
2026-02-06T22:15:09.891Z  WARN  otap-df-controller::core_affinity.set_failed (crates/controller/src/lib.rs:668): 
```
(Missing message!)

After (i.e with this PR)
```txt
2026-02-06T22:11:19.095Z  WARN  otap-df-controller::core_affinity.set_failed (crates/controller/src/lib.rs:668): Failed to set core affinity for pipeline thread. Performance may be less predictable.
```
(Message is back)

"message" is already special cased in this repo, OTel Rust repo, and
`tracing` itself. Passing user friendly string as an attribute named
"message" is
*[faster](https://github.com/open-telemetry/opentelemetry-rust/pull/2001/changes)*
too!

Also, we avoid the less friendly syntax -
#1981 (comment)
Comment thread rust/otap-dataflow/crates/telemetry/src/registry.rs Outdated
Comment thread rust/otap-dataflow/crates/telemetry/src/registry.rs Outdated
@jmacd jmacd added this pull request to the merge queue Feb 6, 2026
Merged via the queue into open-telemetry:main with commit 26af8da Feb 7, 2026
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants