Fix internal logging macros#1985
Merged
jmacd merged 1 commit intoopen-telemetry:mainfrom Feb 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 85.77% 85.76% -0.01%
==========================================
Files 513 513
Lines 162920 162908 -12
==========================================
- Hits 139737 139723 -14
- Misses 22649 22651 +2
Partials 534 534
🚀 New features to boost your workflow:
|
Contributor
|
😞 sorry, Cijo, for my eager button-pressing in #1973. |
Member
Author
Contributor
|
This is not adding the message as body. I still prefer as it was, as it did not restrict the usage of message as attribute (it is more flexible). |
Member
Author
https://github.com/open-telemetry/otel-arrow/blob/main/rust/otap-dataflow/crates/telemetry/src/self_tracing/encoder.rs#L268-L269 "message" attribute becomes Body :) |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting #1973
Fixing the empty "" from our internal macros, that caused the
message="user friendly message here"from being omitted in stdout!Taking https://github.com/open-telemetry/otel-arrow/blob/main/rust/otap-dataflow/crates/controller/src/lib.rs#L668-L671 as example
Before
(Missing message!)
After (i.e with this PR)
(Message is back)
"message" is already special cased in this repo, OTel Rust repo, and
tracingitself. Passing user friendly string as an attribute named "message" is faster too!Also, we avoid the less friendly syntax - #1981 (comment)