Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions rust/otap-dataflow/crates/otap/src/otlp_receiver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -483,15 +483,22 @@ impl shared::Receiver<OtapPdata> for OTLPReceiver {
effect_handler: shared::EffectHandler<OtapPdata>,
) -> Result<TerminalState, Error> {
let grpc_enabled = self.config.protocols.grpc.is_some();
let http_enabled = self.config.protocols.http.is_some();
let both_enabled = self.config.protocols.has_both();

otap_df_telemetry::otel_info!(
"receiver.start",
message = "Starting OTLP Receiver",
grpc_enabled = grpc_enabled,
http_enabled = http_enabled
);
if let Some(grpc) = &self.config.protocols.grpc {
otap_df_telemetry::otel_info!(
"otlp.receiver.grpc.start",
message = "Starting OTLP gRPC receiver",
endpoint = %grpc.listening_addr
);
}
if let Some(http) = &self.config.protocols.http {
otap_df_telemetry::otel_info!(
"otlp.receiver.http.start",
message = "Starting OTLP HTTP receiver",
endpoint = %http.listening_addr
);
}

// Determine per-protocol concurrency limits. These are tuned in
// `tune_max_concurrent_requests()` to not exceed downstream capacity.
Expand Down
4 changes: 2 additions & 2 deletions rust/otap-dataflow/crates/telemetry/src/registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use crate::entity::{EntityRegistry, RegisterOutcome};
use crate::metrics::{
MetricSet, MetricSetHandler, MetricSetRegistry, MetricValue, MetricsIterator,
};
use crate::otel_info;
use crate::otel_debug;
use crate::semconv::SemConvRegistry;
use parking_lot::Mutex;
use slotmap::new_key_type;
Expand Down Expand Up @@ -76,7 +76,7 @@ impl TelemetryRegistryHandle {
// TODO(#1907): This could benefit from logging a human-readable form
// of the entity that we refer to later in the logs, instead of logging
// every key/value in every line of console_async output.
otel_info!("registry.define_entity", schema, definition);
Comment thread
cijothomas marked this conversation as resolved.
otel_debug!("registry.define_entity", schema, definition);
}
outcome.key()
}
Expand Down
Loading