Appender-Tracing benchmark to pass message as attribute - 10% faster#2001
Merged
lalitb merged 4 commits intoopen-telemetry:mainfrom Aug 9, 2024
Merged
Conversation
cijothomas
changed the title
cijothomas
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
=====================================
Coverage 74.8% 74.8%
=====================================
Files 122 122
Lines 20678 20686 +8
=====================================
+ Hits 15474 15482 +8
Misses 5204 5204 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Aug 9, 2024
4 tasks
bantonsson
pushed a commit
to bantonsson/opentelemetry-rust
that referenced
this pull request
Oct 9, 2025
takumi-earth
pushed a commit
to earthlings-dev/opentelemetry-rust
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracing appender benchmarks were using textual message, which is less performant that putting them as structured key-value pair.
https://docs.rs/tracing/latest/tracing/event/struct.Event.html mentions majority should be using fields, but does not strongly recommend against textual message. We (OTel) should prefer showing examples with fields only and no messages. I put a TODO in the appender to special case "message" to populate body.
Simply removing the textual message and storing the same content in a named field (in benchmark), shows 10% perf gain, which shows how much worse is not using fields. For fields, we current allocate+copy the string, but that is something to be revisited and fixed later, which should further speed this up.