Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk-metrics): replace MetricsAttributes with Attributes #5021

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

Replaces MetricsAttributes with Attributes

Refs #4175

Short description of the changes

Replace the interfaces in sources & tests.

How Has This Been Tested?

at the root folder

  • npm run compile
  • npm run test

@david-luna david-luna requested a review from a team as a code owner September 26, 2024 15:12
@david-luna david-luna changed the title Dluna/4175 replace metricsattrib interfaces sdk metrics refactor(sdk-metrics): replace MetricsAttributes with Attributes Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (f8ab559) to head (fa06e47).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5021      +/-   ##
==========================================
+ Coverage   93.39%   93.92%   +0.53%     
==========================================
  Files          46      310     +264     
  Lines         712     8138    +7426     
  Branches      120     1633    +1513     
==========================================
+ Hits          665     7644    +6979     
- Misses         47      494     +447     
Files with missing lines Coverage Δ
packages/sdk-metrics/src/Instruments.ts 96.00% <100.00%> (ø)
packages/sdk-metrics/src/ObservableResult.ts 100.00% <100.00%> (ø)
packages/sdk-metrics/src/aggregator/types.ts 100.00% <ø> (ø)
...xemplar/AlignedHistogramBucketExemplarReservoir.ts 92.30% <ø> (ø)
...metrics/src/exemplar/AlwaysSampleExemplarFilter.ts 100.00% <ø> (ø)
...ages/sdk-metrics/src/exemplar/ExemplarReservoir.ts 95.65% <100.00%> (ø)
...-metrics/src/exemplar/NeverSampleExemplarFilter.ts 100.00% <ø> (ø)
...s/src/exemplar/SimpleFixedSizeExemplarReservoir.ts 77.77% <ø> (ø)
...dk-metrics/src/exemplar/WithTraceExemplarFilter.ts 100.00% <ø> (ø)
packages/sdk-metrics/src/export/MetricData.ts 100.00% <ø> (ø)
... and 5 more

... and 251 files with indirect coverage changes

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🙂

@pichlermarc pichlermarc added this pull request to the merge queue Sep 27, 2024
Merged via the queue into open-telemetry:main with commit 466140b Sep 27, 2024
21 checks passed
@david-luna david-luna deleted the dluna/4175-replace-metricsattrib-interfaces-sdk-metrics branch November 12, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants